D12226: balooshow: Colorize only when attached to terminal
michaelh created this revision. michaelh added a reviewer: Baloo. Restricted Application added projects: Frameworks, Baloo. Restricted Application added a subscriber: Frameworks. michaelh requested review of this revision. TEST PLAN $ balooshow otto.txt $ balooshow otto.txt | head -n 12 REPOSITORY R293 Baloo BRANCH no-color (branched from master) REVISION DETAIL https://phabricator.kde.org/D12226 AFFECTED FILES src/tools/balooshow/main.cpp To: michaelh, #baloo Cc: #frameworks, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, alexeymin
D12226: balooshow: Colorize only when attached to terminal
bruns added reviewers: bruns, FreeBSD. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D12226 To: michaelh, #baloo, bruns, #freebsd Cc: #frameworks, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, alexeymin
D12226: balooshow: Colorize only when attached to terminal
bruns accepted this revision. bruns added a comment. LGTM Can somebody FreeBSD folk confirm this works also on FreeBSD? REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D12226 To: michaelh, #baloo, bruns, #freebsd Cc: #frameworks, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, alexeymin
D12226: balooshow: Colorize only when attached to terminal
tcberner accepted this revision. tcberner added a comment. This revision is now accepted and ready to land. Works as intended on FreeBSD. REPOSITORY R293 Baloo BRANCH no-color (branched from master) REVISION DETAIL https://phabricator.kde.org/D12226 To: michaelh, #baloo, bruns, #freebsd, tcberner Cc: tcberner, #frameworks, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns
D12226: balooshow: Colorize only when attached to terminal
michaelh updated this revision to Diff 32256. michaelh added a comment. - Rebase REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12226?vs=32193&id=32256 BRANCH no-color (branched from master) REVISION DETAIL https://phabricator.kde.org/D12226 AFFECTED FILES src/tools/balooshow/main.cpp To: michaelh, #baloo, bruns, #freebsd, tcberner Cc: tcberner, #frameworks, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns
D12226: balooshow: Colorize only when attached to terminal
This revision was automatically updated to reflect the committed changes. Closed by commit R293:094d6e90d4c0: balooshow: Colorize only when attached to terminal (authored by michaelh). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12226?vs=32256&id=32257 REVISION DETAIL https://phabricator.kde.org/D12226 AFFECTED FILES src/tools/balooshow/main.cpp To: michaelh, #baloo, bruns, #freebsd, tcberner Cc: tcberner, #frameworks, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns
