D12227: Save the dialog view settings even when canceling
ngraham added a task: T8552: Polish Open/Save dialogs. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12227 To: ngraham, #frameworks, davidedmundson Cc: michaelh, bruns
D12227: Save the dialog view settings even when canceling
ngraham closed this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12227 To: ngraham, #frameworks, davidedmundson Cc: michaelh, bruns
D12227: Save the dialog view settings even when canceling
davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH save-dialog-view-settings-on-cancel (branched from master) REVISION DETAIL https://phabricator.kde.org/D12227 To: ngraham, #frameworks, davidedmundson Cc: michaelh, bruns
D12227: Save the dialog view settings even when canceling
ngraham added a dependent revision: D12240: Save the dialog view settings when closing the dialog without hitting the cancel button. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12227 To: ngraham, #frameworks Cc: michaelh, ngraham, bruns
D12227: Save the dialog view settings even when canceling
ngraham edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12227 To: ngraham, #frameworks Cc: michaelh, ngraham, bruns
D12227: Save the dialog view settings even when canceling
ngraham edited the test plan for this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12227 To: ngraham, #frameworks Cc: michaelh, ngraham, bruns
D12227: Save the dialog view settings even when canceling
ngraham created this revision. ngraham added a reviewer: Frameworks. Restricted Application added a project: Frameworks. ngraham requested review of this revision. REVISION SUMMARY Currently, for file Open & Save dialogs, any view settings you've changed are only remembered if you actually open or save the file; they're ignored if you cancel the dialog using the Cancel button. This patch fixes that, since there's no particular reason why a user should want to discard any view changes just because they decided not to open or save the file. BUG: 209559 FIXED-IN: 5.46 TEST PLAN Open a file open or save dialog, change the view, hit the cancel button, then open it again. Note: this patch does //not// fix the case of the view not being saved when closing the dialog via the [⎋] key or the titlebar close button; those cases need to be separately handled in the QPA theme plugin, which actually creates the dialog window. REPOSITORY R241 KIO BRANCH save-dialog-view-settings-on-cancel (branched from master) REVISION DETAIL https://phabricator.kde.org/D12227 AFFECTED FILES src/filewidgets/kfilewidget.cpp To: ngraham, #frameworks Cc: michaelh, ngraham, bruns
