D12239: Create a public writeViewConfig() function so the open/save dialog itself can call it

[Nathaniel Graham]

ngraham created this revision.
ngraham added a reviewer: Frameworks.
Restricted Application added a project: Frameworks.
ngraham requested review of this revision.

REVISION SUMMARY
  D12227  fixes 209559 for the case when 
the user presses the Cancel button, but not when the dialog is closed via the 
Escape key or the titlebar's close button. In order to do that, changes to the 
QPA plugin are needed. To facilitate it, `KFileWidget` needs a public interface 
to the `writeViewConfig()` function needs so that the dialog can call it. THis 
patch does that.

TEST PLAN
  Compile and deploy KIO, run tests (no regressions),  interact with a file 
open/save dialog; all still work

REPOSITORY
  R241 KIO

BRANCH
  public-writeviewconfig-function

REVISION DETAIL
  https://phabricator.kde.org/D12239

AFFECTED FILES
  src/filewidgets/kfilewidget.cpp
  src/filewidgets/kfilewidget.h

To: ngraham, #frameworks
Cc: michaelh, ngraham, bruns

D12239: Create a public writeViewConfig() function so the open/save dialog itself can call it

[Nathaniel Graham]

ngraham added a dependent revision: D12240: Save the dialog view settings when 
closing the dialog without hitting the cancel button.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D12239

To: ngraham, #frameworks
Cc: michaelh, ngraham, bruns

D12239: Create a public writeViewConfig() function so the open/save dialog itself can call it

[Nathaniel Graham]

ngraham edited the summary of this revision.
ngraham edited the test plan for this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D12239

To: ngraham, #frameworks
Cc: michaelh, ngraham, bruns

D12239: Create a public writeViewConfig() function so the open/save dialog itself can call it

[Nathaniel Graham]

ngraham abandoned this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D12239

To: ngraham, #frameworks
Cc: anthonyfieroni, michaelh, ngraham, bruns

D12239: Create a public writeViewConfig() function so the open/save dialog itself can call it

[Nathaniel Graham]

ngraham added a subscriber: anthonyfieroni.
ngraham added a comment.


  Don't need this anymore, since @anthonyfieroni showed me a much better way to 
accomplish D12240 !

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D12239

To: ngraham, #frameworks
Cc: anthonyfieroni, michaelh, ngraham, bruns

D12239: Create a public writeViewConfig() function so the open/save dialog itself can call it

[Nathaniel Graham]

ngraham removed a dependent revision: D12240: Save the dialog view settings 
when closing the dialog without hitting the cancel button.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D12239

To: ngraham, #frameworks
Cc: anthonyfieroni, michaelh, ngraham, bruns