D12244: new resize policy

2018-04-16 Thread Marco Martin 
This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R296:ed25dc538941: new resize policy (authored by mart).

REPOSITORY
  R296 KDeclarative

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12244?vs=32291=32292

REVISION DETAIL
  https://phabricator.kde.org/D12244

AFFECTED FILES
  src/qmlcontrols/kcmcontrols/qml/GridDelegate.qml
  src/qmlcontrols/kcmcontrols/qml/GridView.qml
  src/qmlcontrols/kcmcontrols/qml/GridViewKCM.qml

To: mart, #vdg, #plasma
Cc: broulik, #frameworks, michaelh, ngraham, bruns

D12244: new resize policy

2018-04-16 Thread Marco Martin 
mart updated this revision to Diff 32291.
mart added a comment.


  - ensure items never overlap

REPOSITORY
  R296 KDeclarative

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12244?vs=32287=32291

BRANCH
  phab/newResizing

REVISION DETAIL
  https://phabricator.kde.org/D12244

AFFECTED FILES
  src/qmlcontrols/kcmcontrols/qml/GridDelegate.qml
  src/qmlcontrols/kcmcontrols/qml/GridView.qml
  src/qmlcontrols/kcmcontrols/qml/GridViewKCM.qml

To: mart, #vdg, #plasma
Cc: broulik, #frameworks, michaelh, ngraham, bruns

D12244: new resize policy

2018-04-16 Thread Kai Uwe Broulik 
broulik added a comment.


  Fine in principle but it doesn't enforce any minimum spacing
  F5809738: Screenshot_20180416_164705.png 


REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D12244

To: mart, #vdg, #plasma
Cc: broulik, #frameworks, michaelh, ngraham, bruns

D12244: new resize policy

2018-04-16 Thread Marco Martin 
mart updated this revision to Diff 32287.
mart added a comment.


  - better centering

REPOSITORY
  R296 KDeclarative

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12244?vs=32280=32287

BRANCH
  phab/newResizing

REVISION DETAIL
  https://phabricator.kde.org/D12244

AFFECTED FILES
  src/qmlcontrols/kcmcontrols/qml/GridDelegate.qml
  src/qmlcontrols/kcmcontrols/qml/GridView.qml
  src/qmlcontrols/kcmcontrols/qml/GridViewKCM.qml

To: mart, #vdg, #plasma
Cc: #frameworks, michaelh, ngraham, bruns

D12244: new resize policy

2018-04-16 Thread Marco Martin 
mart added a dependent revision: D12090: port the look and feel kcm to new 
design.

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D12244

To: mart, #vdg, #plasma
Cc: #frameworks, michaelh, ngraham, bruns

D12244: new resize policy

2018-04-16 Thread Marco Martin 
mart added a dependent revision: D12088: port the ksplash kcm to the new design.

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D12244

To: mart, #vdg, #plasma
Cc: #frameworks, michaelh, ngraham, bruns

D12244: new resize policy

2018-04-16 Thread Marco Martin 
mart updated this revision to Diff 32280.
mart added a comment.


  - binding loops --

REPOSITORY
  R296 KDeclarative

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12244?vs=32274=32280

BRANCH
  phab/newResizing

REVISION DETAIL
  https://phabricator.kde.org/D12244

AFFECTED FILES
  src/qmlcontrols/kcmcontrols/qml/GridDelegate.qml
  src/qmlcontrols/kcmcontrols/qml/GridView.qml
  src/qmlcontrols/kcmcontrols/qml/GridViewKCM.qml

To: mart, #vdg, #plasma
Cc: #frameworks, michaelh, ngraham, bruns

D12244: new resize policy

2018-04-16 Thread Marco Martin 
mart added a comment.


  F5809678: vokoscreen-2018-04-16_14-49-45.mkv 


REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D12244

To: mart, #vdg, #plasma
Cc: #frameworks, michaelh, ngraham, bruns

D12244: new resize policy

2018-04-16 Thread Nathaniel Graham 
ngraham edited the summary of this revision.

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D12244

To: mart, #vdg, #plasma
Cc: #frameworks, michaelh, ngraham, bruns

D12244: new resize policy

2018-04-16 Thread Marco Martin 
mart added a comment.


  https://www.youtube.com/watch?v=6sXGiGUOSLU=youtu.be
  https://www.youtube.com/watch?v=yN736sDWPHY=youtu.be

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D12244

To: mart, #vdg, #plasma
Cc: #frameworks, michaelh, ngraham, bruns

D12244: new resize policy

2018-04-16 Thread Marco Martin 
mart edited the test plan for this revision.

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D12244

To: mart, #vdg, #plasma
Cc: #frameworks, michaelh, ngraham, bruns

D12244: new resize policy

2018-04-16 Thread Marco Martin 
mart added a reviewer: Plasma.

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D12244

To: mart, #vdg, #plasma
Cc: #frameworks, michaelh, ngraham, bruns

D12244: new resize policy

2018-04-16 Thread Marco Martin 
mart created this revision.
mart added a reviewer: VDG.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
mart requested review of this revision.

REVISION SUMMARY
  the grid view always takes the full kcm
  the extra space is added as space between icons columns

TEST PLAN
  ted on various sizes

REPOSITORY
  R296 KDeclarative

BRANCH
  phab/newResizing

REVISION DETAIL
  https://phabricator.kde.org/D12244

AFFECTED FILES
  src/qmlcontrols/kcmcontrols/qml/GridDelegate.qml
  src/qmlcontrols/kcmcontrols/qml/GridView.qml
  src/qmlcontrols/kcmcontrols/qml/GridViewKCM.qml

To: mart, #vdg
Cc: #frameworks, michaelh, ngraham, bruns