D12247: Use "Do x" action texts for drop menu entries

[Friedrich W . H . Kossebau]

This revision was automatically updated to reflect the committed changes.
Closed by commit R242:de1fde829870: Use "Do x" action texts for drop 
menu entries (authored by kossebau).

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12247?vs=32283&id=33068

REVISION DETAIL
  https://phabricator.kde.org/D12247

AFFECTED FILES
  src/scriptengines/qml/plasmoid/containmentinterface.cpp

To: kossebau, #vdg, #plasma, davidedmundson
Cc: ngraham, #frameworks, michaelh, bruns

D12247: Use "Do x" action texts for drop menu entries

[David Edmundson]

davidedmundson accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  containmentdropmenudoactions

REVISION DETAIL
  https://phabricator.kde.org/D12247

To: kossebau, #vdg, #plasma, davidedmundson
Cc: ngraham, #frameworks, michaelh, bruns

D12247: Use "Do x" action texts for drop menu entries

[Nathaniel Graham]

ngraham added a comment.


  In D12247#247328 , @kossebau wrote:
  
  > Alternativly one could change those menu section titles (which sadly are 
hard to recognize as such with Breeze theme)
  
  
  Agreed, this definitely needs improvement.
  
  In D12247#247328 , @kossebau wrote:
  
  > to be "Add Widgets" and "Set Wallpaper", and then list the widgets and 
wallpapers by their name as before, as kind of inlined submenus.
  >  Though that approach might conflict with some other potential entries in 
that menu, with ""Plasma Package" for the section and "Install" as menu entry. 
Possibly might need a complete overhaul then.
  
  
  I prefer your original approach of simply adding verbs.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D12247

To: kossebau, #vdg, #plasma
Cc: ngraham, #frameworks, michaelh, bruns

D12247: Use "Do x" action texts for drop menu entries

[Friedrich W . H . Kossebau]

kossebau added a comment.


  Alternativly one could change those menu section titles (which sadly are hard 
to recognize as such with Breeze theme) to be "Add Widgets" and "Set 
Wallpaper", and then list the widgets and wallpapers by their name as before, 
as kind of inlined submenus.
  Though that approach might conflict with some other potential entries in that 
menu, with ""Plasma Package" for the section and "Install" as menu entry. 
Possibly might need a complete overhaul then.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D12247

To: kossebau, #vdg, #plasma
Cc: #frameworks, michaelh, ngraham, bruns

D12247: Use "Do x" action texts for drop menu entries

[Friedrich W . H . Kossebau]

kossebau added a comment.


  Example of dropping an SVG file onto the background:
  
  Before:
  F5809685: Screenshot_20180416_151514.png 

  After:
  F5809689: Screenshot_20180416_150907.png 


REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D12247

To: kossebau, #vdg, #plasma
Cc: #frameworks, michaelh, ngraham, bruns

D12247: Use "Do x" action texts for drop menu entries

[Friedrich W . H . Kossebau]

kossebau created this revision.
kossebau added reviewers: VDG, Plasma.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
kossebau requested review of this revision.

REVISION SUMMARY
  Dropping some item onto a containment results in a menu which lists widgets
  and wallpaper plugins without explicitly telling what will happen onto
  activation.
  
  Changing the menu entries into "Add widget" and "Set wallpaper" makes it
  more obvious what they will result in.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  containmentdropmenudoactions

REVISION DETAIL
  https://phabricator.kde.org/D12247

AFFECTED FILES
  src/scriptengines/qml/plasmoid/containmentinterface.cpp

To: kossebau, #vdg, #plasma
Cc: #frameworks, michaelh, ngraham, bruns