D12283: Allow to load dictionaries form a rcc

[Hannah von Reth]

vonreth abandoned this revision.
vonreth added a comment.


  as we now have a native windows backend there is no point in this

REPOSITORY
  R246 Sonnet

REVISION DETAIL
  https://phabricator.kde.org/D12283

To: vonreth, mlaurent
Cc: ahmadsamir, kde-frameworks-devel, habacker, LeGast00n, cblack, GB_2, 
michaelh, ngraham, bruns

D12283: Allow to load dictionaries form a rcc

[Ahmad Samir]

ahmadsamir added a comment.


  IINM, in the commit message s/form a rcc/from an rcc/.

REPOSITORY
  R246 Sonnet

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D12283

To: vonreth, mlaurent
Cc: ahmadsamir, kde-frameworks-devel, habacker, LeGast00n, GB_2, michaelh, 
ngraham, bruns

D12283: Allow to load dictionaries form a rcc

[Ralf Habacker]

habacker added a comment.
Herald edited subscribers, added: kde-frameworks-devel; removed: Frameworks.


  In D12283#249520 , @vonreth wrote:
  
  > While the disk use of the installation goes down the ram usage explodes as 
QResource doesn't use mmap 
https://github.com/qt/qtbase/blob/a37dd93defd91b79fb6730d0ff0515a66a0d3972/src/corelib/io/qresource.cpp#L1037
  
  
  Would adding a mmap implementation on Windows like 
https://github.com/witwall/mman-win32 be an option  ?

REPOSITORY
  R246 Sonnet

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D12283

To: vonreth, mlaurent
Cc: kde-frameworks-devel, habacker, LeGast00n, GB_2, michaelh, ngraham, bruns, 
#frameworks

D12283: Allow to load dictionaries form a rcc

[Hannah von Reth]

vonreth added a comment.


  While the disk use of the installation goes down the ram usage explodes as 
QResource doesn't use mmap 
https://github.com/qt/qtbase/blob/a37dd93defd91b79fb6730d0ff0515a66a0d3972/src/corelib/io/qresource.cpp#L1037

REPOSITORY
  R246 Sonnet

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D12283

To: vonreth, mlaurent
Cc: #frameworks, michaelh, bruns

D12283: Allow to load dictionaries form a rcc

[Laurent Montel]

mlaurent added inline comments.

INLINE COMMENTS

> hunspelldict.cpp:104
>  delete m_speller;
> +if (m_tempDir) {
> +delete m_tempDir;

not necessary to check pointer here.

REPOSITORY
  R246 Sonnet

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D12283

To: vonreth, mlaurent
Cc: #frameworks, michaelh, bruns

D12283: Allow to load dictionaries form a rcc

[Hannah von Reth]

vonreth updated this revision to Diff 32445.
vonreth added a comment.


  Write resources to tmpDir before passing them to hunspell

REPOSITORY
  R246 Sonnet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12283?vs=32441&id=32445

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D12283

AFFECTED FILES
  src/plugins/hunspell/hunspellclient.cpp
  src/plugins/hunspell/hunspellclient.h
  src/plugins/hunspell/hunspelldict.cpp
  src/plugins/hunspell/hunspelldict.h

To: vonreth, mlaurent
Cc: #frameworks, michaelh, bruns

D12283: Allow to load dictionaries form a rcc

[Hannah von Reth]

vonreth added a comment.


  Turns out that my test was a bit too small.
  While sonnet finds the dicts and marked my random typed stuff as wrong it 
also marks everything as wrong.
  
  Sonnet might have no problems with the rcc but hunspell has.
  
Hunspell(const char* affpath, const char* dpath, const char* key = NULL);
  
  The constructor only takes a file path and creates an invalid speller if the 
file does not exist.
  
  So I guess I'm going to abandon the review

REPOSITORY
  R246 Sonnet

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D12283

To: vonreth, mlaurent
Cc: #frameworks, michaelh, bruns

D12283: Allow to load dictionaries form a rcc

[Hannah von Reth]

vonreth edited the summary of this revision.

REPOSITORY
  R246 Sonnet

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D12283

To: vonreth, mlaurent
Cc: #frameworks, michaelh, bruns

D12283: Allow to load dictionaries form a rcc

[Hannah von Reth]

vonreth updated this revision to Diff 32441.
vonreth added a comment.


  Changed the lookup location for the rcc

REPOSITORY
  R246 Sonnet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12283?vs=32394&id=32441

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D12283

AFFECTED FILES
  src/plugins/hunspell/hunspellclient.cpp
  src/plugins/hunspell/hunspellclient.h

To: vonreth, mlaurent
Cc: #frameworks, michaelh, bruns

D12283: Allow to load dictionaries form a rcc

[Laurent Montel]

mlaurent accepted this revision.
mlaurent added a comment.
This revision is now accepted and ready to land.


  Remove indent and commit it :)
  Thanks

INLINE COMMENTS

> hunspellclient.cpp:104
> +}
> +return QString();
> +}

fix indent

REPOSITORY
  R246 Sonnet

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D12283

To: vonreth, mlaurent
Cc: #frameworks, michaelh, bruns

D12283: Allow to load dictionaries form a rcc

[Hannah von Reth]

vonreth edited the summary of this revision.

REPOSITORY
  R246 Sonnet

REVISION DETAIL
  https://phabricator.kde.org/D12283

To: vonreth, mlaurent
Cc: #frameworks, michaelh, bruns

D12283: Allow to load dictionaries form a rcc

[Hannah von Reth]

vonreth added a reviewer: mlaurent.

REPOSITORY
  R246 Sonnet

REVISION DETAIL
  https://phabricator.kde.org/D12283

To: vonreth, mlaurent
Cc: #frameworks, michaelh, bruns

D12283: Allow to load dictionaries form a rcc

[Hannah von Reth]

vonreth created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
vonreth requested review of this revision.

REPOSITORY
  R246 Sonnet

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D12283

AFFECTED FILES
  src/plugins/hunspell/hunspellclient.cpp
  src/plugins/hunspell/hunspellclient.h

To: vonreth
Cc: #frameworks, michaelh, bruns