D12439: Add EventDataDecorator::hasEndDateTime()

2018-05-02 Thread Friedrich W . H . Kossebau 
kossebau abandoned this revision.
kossebau added a comment.


  Seems code out there is already relying on `!isNaN(datetime)` so let's do the 
same for now. Besides, there can be events with also only end-date, so the same 
check would be needed for the start date, thus this API would be incomplete.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D12439

To: kossebau, #plasma
Cc: broulik, #frameworks, michaelh, bruns

D12439: Add EventDataDecorator::hasEndDateTime()

2018-05-02 Thread Kai Uwe Broulik 
broulik added a comment.


  `!isNaN(endDateTime.getTime())`?

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D12439

To: kossebau, #plasma
Cc: broulik, #frameworks, michaelh, bruns

D12439: Add EventDataDecorator::hasEndDateTime()

2018-04-22 Thread Friedrich W . H . Kossebau 
kossebau created this revision.
kossebau added a reviewer: Plasma.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
kossebau requested review of this revision.

REVISION SUMMARY
  There can be events which have no duration. Those are represented by having
  a start datetime, but no valid end dateTime.
  The new method hasEndDateTime() simplifies querying this from QML.
  
  Follows the API of KCalCore::Event.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  addhasEndDateTime

REVISION DETAIL
  https://phabricator.kde.org/D12439

AFFECTED FILES
  src/declarativeimports/calendar/eventdatadecorator.cpp
  src/declarativeimports/calendar/eventdatadecorator.h

To: kossebau, #plasma
Cc: #frameworks, michaelh, bruns