D12477: Add unit test to see that :/ files can work

[Friedrich W. H. Kossebau]

kossebau added a comment.


  In D12477#403709 , @dfaure wrote:
  
  > Still, at the level of the KParts frameworks itself it's all fine ;)
  
  
  Which "level" do you mean here? This test only works by pure chance given the 
current implementation detail of NotepadPart. It is not  testing something part 
of the API contract,

REPOSITORY
  R306 KParts

REVISION DETAIL
  https://phabricator.kde.org/D12477

To: svuorela, dfaure, kossebau, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D12477: Add unit test to see that :/ files can work

[David Faure]

dfaure added a comment.


  Right, this would fail if the part was not using QFile, indeed. Still, at the 
level of the KParts frameworks itself it's all fine ;)

REPOSITORY
  R306 KParts

REVISION DETAIL
  https://phabricator.kde.org/D12477

To: svuorela, dfaure, kossebau, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D12477: Add unit test to see that :/ files can work

[David Faure]

dfaure accepted this revision.
This revision is now accepted and ready to land.
Herald added a subscriber: kde-frameworks-devel.

REPOSITORY
  R306 KParts

REVISION DETAIL
  https://phabricator.kde.org/D12477

To: svuorela, dfaure, kossebau, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D12477: Add unit test to see that :/ files can work

[Friedrich W . H . Kossebau]

kossebau added a comment.


  It passes only by pure chance as NotepadPart uses QFile, which understands 
such an url. So the value of that new autptest is questionable, as this is not 
testing any API promise.
  
  For `ReadOnlyPart::localFilePath()` it says: "Returns the local file path 
associated with this part. " So a :/ resource url is rather out of scope, at 
least by traditional meaning of "local file path". Any KParts plugins which 
pass the file path on to non-QFile-using code will fall flat on such qrc path.

REPOSITORY
  R306 KParts

REVISION DETAIL
  https://phabricator.kde.org/D12477

To: svuorela, dfaure, kossebau, #frameworks
Cc: michaelh, bruns

D12477: Add unit test to see that :/ files can work

[Sune Vuorela]

svuorela created this revision.
svuorela added reviewers: dfaure, kossebau, Frameworks.
Restricted Application added a project: Frameworks.
svuorela requested review of this revision.

REVISION SUMMARY
  I wasn't sure if :/foo stuff would work, so I tried writing a unit test to 
help me. Let's submit it. It passes

TEST PLAN
  Unit test still passes.

REPOSITORY
  R306 KParts

REVISION DETAIL
  https://phabricator.kde.org/D12477

AFFECTED FILES
  autotests/CMakeLists.txt
  autotests/parttest.cpp
  autotests/parttest.h

To: svuorela, dfaure, kossebau, #frameworks
Cc: michaelh, bruns