D12493: Require NetworkManager 1.4.0 and newer
bruns added a comment. You have missed the checks added in https://phabricator.kde.org/D11353, e.g. in src/dnsconfiguration.h Also, the API documentation has a lot of `@note`s referencing NM < 1.2.0, 1.0.6, ... REPOSITORY R282 NetworkManagerQt REVISION DETAIL https://phabricator.kde.org/D12493 To: jgrulich, #frameworks, sitter Cc: bruns, kde-frameworks-devel, #frameworks, michaelh, ngraham
D12493: Require NetworkManager 1.4.0 and newer
This revision was automatically updated to reflect the committed changes. Closed by commit R282:d5d45a61e324: Require NetworkManager 1.4.0 and newer (authored by jgrulich). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D12493?vs=32965&id=40692#toc REPOSITORY R282 NetworkManagerQt CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12493?vs=32965&id=40692 REVISION DETAIL https://phabricator.kde.org/D12493 AFFECTED FILES CMakeLists.txt autotests/settings/8021xsettingtest.cpp autotests/settings/bridgesettingtest.cpp autotests/settings/connectionsettingtest.cpp autotests/settings/gsmsettingtest.cpp autotests/settings/vpnsettingtest.cpp autotests/settings/wiredsettingtest.cpp autotests/settings/wirelesssettingtest.cpp src/accesspoint.cpp src/activeconnection.cpp src/adsldevice.cpp src/bluetoothdevice.cpp src/bonddevice.cpp src/bridgedevice.cpp src/connection.cpp src/devicestatistics.cpp src/dhcp4config.cpp src/dhcp6config.cpp src/genericdevice.cpp src/gredevice.cpp src/infinibanddevice.cpp src/iptunneldevice.cpp src/macvlandevice.cpp src/manager.cpp src/modemdevice.cpp src/olpcmeshdevice.cpp src/settings.cpp src/settings/bridgesetting.cpp src/settings/connectionsettings.cpp src/settings/gsmsetting.cpp src/settings/security8021xsetting.cpp src/settings/tunsetting.cpp src/settings/vpnsetting.cpp src/settings/wiredsetting.cpp src/settings/wirelesssetting.cpp src/teamdevice.cpp src/tundevice.cpp src/vethdevice.cpp src/vlandevice.cpp src/vpnconnection.cpp src/wimaxdevice.cpp src/wireddevice.cpp src/wirelessdevice.cpp To: jgrulich, #frameworks, sitter Cc: kde-frameworks-devel, #frameworks, michaelh, ngraham, bruns
D12493: Require NetworkManager 1.4.0 and newer
sitter accepted this revision. This revision is now accepted and ready to land. Herald added a subscriber: kde-frameworks-devel. REPOSITORY R282 NetworkManagerQt BRANCH master REVISION DETAIL https://phabricator.kde.org/D12493 To: jgrulich, #frameworks, sitter Cc: kde-frameworks-devel, #frameworks, michaelh, ngraham, bruns
D12493: Require NetworkManager 1.4.0 and newer
jgrulich added a reviewer: Frameworks. REPOSITORY R282 NetworkManagerQt REVISION DETAIL https://phabricator.kde.org/D12493 To: jgrulich, #frameworks Cc: #frameworks, michaelh, bruns
D12493: Require NetworkManager 1.4.0 and newer
jgrulich created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. jgrulich requested review of this revision. REVISION SUMMARY NM 1.4.0 was released in 2016, even Debian stable has newer version in repositories so it shouldn't be problem to require it. We can remove almost all checks for NM versions and it will also simplify code for upcoming changes. REPOSITORY R282 NetworkManagerQt BRANCH master REVISION DETAIL https://phabricator.kde.org/D12493 AFFECTED FILES CMakeLists.txt autotests/settings/8021xsettingtest.cpp autotests/settings/bridgesettingtest.cpp autotests/settings/connectionsettingtest.cpp autotests/settings/gsmsettingtest.cpp autotests/settings/vpnsettingtest.cpp autotests/settings/wiredsettingtest.cpp autotests/settings/wirelesssettingtest.cpp src/accesspoint.cpp src/activeconnection.cpp src/adsldevice.cpp src/bluetoothdevice.cpp src/bonddevice.cpp src/bridgedevice.cpp src/connection.cpp src/devicestatistics.cpp src/dhcp4config.cpp src/dhcp6config.cpp src/genericdevice.cpp src/gredevice.cpp src/infinibanddevice.cpp src/iptunneldevice.cpp src/macvlandevice.cpp src/manager.cpp src/modemdevice.cpp src/olpcmeshdevice.cpp src/settings.cpp src/settings/bridgesetting.cpp src/settings/connectionsettings.cpp src/settings/gsmsetting.cpp src/settings/security8021xsetting.cpp src/settings/tunsetting.cpp src/settings/vpnsetting.cpp src/settings/wiredsetting.cpp src/settings/wirelesssetting.cpp src/teamdevice.cpp src/tundevice.cpp src/vethdevice.cpp src/vlandevice.cpp src/vpnconnection.cpp src/wimaxdevice.cpp src/wireddevice.cpp src/wirelessdevice.cpp To: jgrulich Cc: #frameworks, michaelh, bruns
