D12756: [KDateTable] Use more appropriate and readable text colors for weekends and holidays

[Christoph Feck]

cfeck added a reviewer: VDG.
cfeck added a comment.


  I love how phabricator thinks I wanted to remove anyone.

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D12756

To: ngraham, #frameworks, #vdg
Cc: alex-l, rkflx, cfeck, kde-frameworks-devel, mwolff, apol, michaelh, 
ngraham, bruns

D12756: [KDateTable] Use more appropriate and readable text colors for weekends and holidays

[Christoph Feck]

cfeck removed a reviewer: VDG.
cfeck added a comment.


QColor c;
c = QColor(Qt::gray);
qDebug() << c.lightnessF();
c = QColor(Qt::darkGray);
qDebug() << c.lightnessF();
  
  I get:
  0.635294
  0.501961
  
  Both colors are very similar and neither has enough contrast for background 
colors with lightness at 0.55.
  
  Additionally, I would prefer computing the brightness of a color using 
qGray() or something similar to account for the different luminances of the 
primary colors.

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D12756

To: ngraham, #frameworks, #vdg
Cc: alex-l, rkflx, cfeck, kde-frameworks-devel, mwolff, apol, michaelh, 
ngraham, bruns

D12756: [KDateTable] Use more appropriate and readable text colors for weekends and holidays

[Alessandro Longo]

alex-l added a comment.


  Gray seems OK to me. And I confirm the bug with Saturday column.

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D12756

To: ngraham, #frameworks, #vdg
Cc: alex-l, rkflx, cfeck, kde-frameworks-devel, mwolff, apol, michaelh, 
ngraham, bruns

D12756: [KDateTable] Use more appropriate and readable text colors for weekends and holidays

[Nathaniel Graham]

ngraham added a comment.


  I don't know. Perhaps it's time to involve more VDG people. #VDG 
, how should we style weekend days and 
day names? Currently we draw them in dark red, which is problematic for a few 
reasons:
  
  F5869969: Screenshot_20180526_075443.png 

  
  (This screenshot also exposes another bug: in my locale, Saturdays are 
inexplicably marked as work days, even though the "sat" header gets the correct 
color)

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D12756

To: ngraham, #frameworks, #vdg
Cc: rkflx, cfeck, kde-frameworks-devel, mwolff, apol, michaelh, ngraham, bruns

D12756: [KDateTable] Use more appropriate and readable text colors for weekends and holidays

[Henrik Fehlauer]

rkflx added a comment.


  In D12756#268345 , @ngraham wrote:
  
  > Use conditional grays instead of reds (red was never an appropriate color 
anyway)
  
  
  Hm, now Sundays look like they belong to the previous/next month. (Do we even 
need to change colour everywhere, or would it be enough to only highlight the 
weekend in the header?)
  
  You could also look at the way KDE3 styled this (see 
https://edu.kde.org/kstars/feature/SetTime.png).

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D12756

To: ngraham, #frameworks, #vdg
Cc: rkflx, cfeck, kde-frameworks-devel, mwolff, apol, michaelh, ngraham, bruns

D12756: [KDateTable] Use more appropriate and readable text colors for weekends and holidays

[Nathaniel Graham]

ngraham edited the summary of this revision.

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D12756

To: ngraham, #frameworks, #vdg
Cc: cfeck, kde-frameworks-devel, mwolff, apol, michaelh, ngraham, bruns

D12756: [KDateTable] Use more appropriate and readable text colors for weekends and holidays

[Nathaniel Graham]

ngraham added a reviewer: VDG.

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D12756

To: ngraham, #frameworks, #vdg
Cc: cfeck, kde-frameworks-devel, mwolff, apol, michaelh, ngraham, bruns

D12756: [KDateTable] Use more appropriate and readable text colors for weekends and holidays

[Nathaniel Graham]

ngraham retitled this revision from "[KDateTable] Use a more visible red color" 
to "[KDateTable] Use more appropriate and readable text colors for weekends and 
holidays".
ngraham edited the summary of this revision.
ngraham edited the test plan for this revision.

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D12756

To: ngraham, #frameworks
Cc: cfeck, kde-frameworks-devel, mwolff, apol, michaelh, ngraham, bruns