D12765: Use a more intuitive, user-friendly name for Samba share access

[Nathaniel Graham]

ngraham created this revision.
ngraham added reviewers: Frameworks, Dolphin, VDG.
ngraham requested review of this revision.

REVISION SUMMARY
  "Samba shares" is a jargonistic term that won't mean much to most people. 
This patch replaces it with a more intuitive and user-friendly term.
  
  BUG: 141257
  FIXED-IN: 18.08.0

REPOSITORY
  R320 KIO Extras

BRANCH
  friendlier-samba-share-name (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D12765

AFFECTED FILES
  smb/smb-network.desktop

To: ngraham, #frameworks, #dolphin, #vdg

D12765: Use a more intuitive, user-friendly name for Samba share access

[Nathaniel Graham]

ngraham edited the test plan for this revision.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D12765

To: ngraham, #frameworks, #dolphin, #vdg

D12765: Use a more intuitive, user-friendly name for Samba share access

[Elvis Angelaccio]

elvisangelaccio added a comment.


  If we remove Samba, how do people who know Samba find where Samba is?
  
  Maybe we can use "Samba Shared Folders" ?

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D12765

To: ngraham, #frameworks, #dolphin, #vdg
Cc: elvisangelaccio

D12765: Use a more intuitive, user-friendly name for Samba share access

[Nathaniel Graham]

ngraham added a comment.


  "Shared folders (Samba)"?
  
  Then again, I doubt that people who know what Samba is will have difficulty 
figuring out that "Shared folders" under the "Network" Place is where Samba 
shares live.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D12765

To: ngraham, #frameworks, #dolphin, #vdg
Cc: elvisangelaccio

D12765: Use a more intuitive, user-friendly name for Samba share access

[Luigi Toscano]

ltoscano added a comment.


  or "Shared folders (SMB)", as the protocol is probably more relevant.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D12765

To: ngraham, #frameworks, #dolphin, #vdg
Cc: ltoscano, elvisangelaccio

D12765: Use a more intuitive, user-friendly name for Samba share access

[Nathaniel Graham]

ngraham added a comment.


  Sounds good to me!

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D12765

To: ngraham, #frameworks, #dolphin, #vdg
Cc: ltoscano, elvisangelaccio

D12765: Use a more intuitive, user-friendly name for Samba share access

[Nathaniel Graham]

ngraham updated this revision to Diff 33844.
ngraham added a comment.


  Add the protocol acronym to help tech-savvy users know what they're looking at

REPOSITORY
  R320 KIO Extras

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12765?vs=33840&id=33844

BRANCH
  friendlier-samba-share-name (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D12765

AFFECTED FILES
  smb/smb-network.desktop

To: ngraham, #frameworks, #dolphin, #vdg
Cc: ltoscano, elvisangelaccio

D12765: Use a more intuitive, user-friendly name for Samba share access

[Nathaniel Graham]

ngraham edited the test plan for this revision.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D12765

To: ngraham, #frameworks, #dolphin, #vdg
Cc: ltoscano, elvisangelaccio

D12765: Use a more intuitive, user-friendly name for Samba share access

[Elvis Angelaccio]

elvisangelaccio added a comment.


  +1

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D12765

To: ngraham, #frameworks, #dolphin, #vdg
Cc: ltoscano, elvisangelaccio

D12765: Use a more intuitive, user-friendly name for Samba share access

[Aleix Pol Gonzalez]

apol accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R320 KIO Extras

BRANCH
  friendlier-samba-share-name (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D12765

To: ngraham, #frameworks, #dolphin, #vdg, apol
Cc: ltoscano, elvisangelaccio

D12765: Use a more intuitive, user-friendly name for Samba share access

[Mark Gaiser]

markg accepted this revision.
markg added a comment.


  Please do note that you have more protocols with shared folders that likely 
deserve a name change in the same fashion.

REPOSITORY
  R320 KIO Extras

BRANCH
  friendlier-samba-share-name (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D12765

To: ngraham, #frameworks, #dolphin, #vdg, apol, markg
Cc: markg, ltoscano, elvisangelaccio

D12765: Use a more intuitive, user-friendly name for Samba share access

[Nathaniel Graham]

ngraham added a comment.


  Which ones, and where do they live?

REPOSITORY
  R320 KIO Extras

BRANCH
  friendlier-samba-share-name (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D12765

To: ngraham, #frameworks, #dolphin, #vdg, apol, markg
Cc: markg, ltoscano, elvisangelaccio

D12765: Use a more intuitive, user-friendly name for Samba share access

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R320:80429a0ed768: Use a more intuitive, user-friendly name 
for Samba share access (authored by ngraham).

REPOSITORY
  R320 KIO Extras

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12765?vs=33844&id=33882

REVISION DETAIL
  https://phabricator.kde.org/D12765

AFFECTED FILES
  smb/smb-network.desktop

To: ngraham, #frameworks, #dolphin, #vdg, apol, markg
Cc: markg, ltoscano, elvisangelaccio

D12765: Use a more intuitive, user-friendly name for Samba share access

[Mark Gaiser]

markg added a comment.


  In D12765#260054 , @ngraham wrote:
  
  > Which ones, and where do they live?
  
  
  I would have expected it for NFS (same repository), but it apparently doesn't 
have a .desktop file at all.
  FTP (lives in the mina kio repo in the ioslaves folder) could have been a 
possibility but also doesn't have a .desktop file.
  
  So no others i suppose.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D12765

To: ngraham, #frameworks, #dolphin, #vdg, apol, markg
Cc: markg, ltoscano, elvisangelaccio