D12768: Allow wrapping selection off top/bottom of autocomplete results
cullmann commandeered this revision. cullmann added a reviewer: sraizada. cullmann added a comment. I don't think such a behavior change is wanted. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D12768 To: cullmann, #ktexteditor, sraizada Cc: dhaumann, cullmann, kwrite-devel, kde-frameworks-devel, brauch, #ktexteditor, michaelh, kevinapavew, ngraham, bruns, demsking, head7, kfunk, sars
D12768: Allow wrapping selection off top/bottom of autocomplete results
cullmann abandoned this revision. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D12768 To: cullmann, #ktexteditor, sraizada Cc: dhaumann, cullmann, kwrite-devel, kde-frameworks-devel, brauch, #ktexteditor, michaelh, kevinapavew, ngraham, bruns, demsking, head7, kfunk, sars
D12768: Allow wrapping selection off top/bottom of autocomplete results
dhaumann added a comment. Indeed, question is if wrapping helps: If you see 5 entries, and you see the last one is correct, then moving up would be ok. But if the completion contains >> 10 entries, this will not work. And then, there is still the "End" key on the keyboard as dedicated action. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D12768 To: sraizada, #ktexteditor Cc: dhaumann, cullmann, kwrite-devel, kde-frameworks-devel, brauch, #ktexteditor, michaelh, kevinapavew, ngraham, bruns, demsking, head7, kfunk, sars
D12768: Allow wrapping selection off top/bottom of autocomplete results
cullmann added a comment. I think the idea was that it is an easy way out of the completion. I am not sure if wrapping is what one would expect. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D12768 To: sraizada, #ktexteditor Cc: dhaumann, cullmann, kwrite-devel, kde-frameworks-devel, brauch, #ktexteditor, michaelh, kevinapavew, ngraham, bruns, demsking, head7, kfunk, sars
D12768: Allow wrapping selection off top/bottom of autocomplete results
dhaumann added subscribers: cullmann, dhaumann. dhaumann added a comment. I remember that @cullmann intentionally implemented it this way: Going upwards will hide the completion list and not wrap around. @cullmann Any take on this? Either accept, or reject. Also, the unit test need fixing obviously... REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D12768 To: sraizada, #ktexteditor Cc: dhaumann, cullmann, kwrite-devel, kde-frameworks-devel, brauch, #ktexteditor, michaelh, kevinapavew, ngraham, bruns, demsking, head7, kfunk, sars
D12768: Allow wrapping selection off top/bottom of autocomplete results
sraizada added a comment. I only use Kate/KWrite so didn't test it on the others previously - sorry. It actually only works in Kate and KWrite, and has no effect on Kile/KDevelop. KDevelop is obviously doing some special stuff, but visually the Kile autocompletion seems identical to the one in Kate/KWrite so I'm surprised that it doesn't work. Any idea what's causing this issue or where I should look in the KDevelop code? REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D12768 To: sraizada, #ktexteditor Cc: kwrite-devel, kde-frameworks-devel, brauch, #ktexteditor, michaelh, kevinapavew, ngraham, bruns, demsking, head7, cullmann, kfunk, sars, dhaumann
D12768: Allow wrapping selection off top/bottom of autocomplete results
sraizada updated this revision to Diff 33884. sraizada added a comment. Restricted Application edited subscribers, added: kde-frameworks-devel, kwrite-devel; removed: Frameworks. Removed unnecessary modifications to code REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12768?vs=33856=33884 REVISION DETAIL https://phabricator.kde.org/D12768 AFFECTED FILES src/completion/katecompletiontree.cpp To: sraizada, #ktexteditor Cc: kwrite-devel, kde-frameworks-devel, brauch, #ktexteditor, michaelh, kevinapavew, ngraham, bruns, demsking, head7, cullmann, kfunk, sars, dhaumann, #frameworks
D12768: Allow wrapping selection off top/bottom of autocomplete results
brauch added a comment. What happens if the overload selection window is open in addition (like in KDevelop)? REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D12768 To: sraizada, #ktexteditor Cc: brauch, #ktexteditor, #frameworks, michaelh, kevinapavew, ngraham, bruns, demsking, head7, cullmann, kfunk, sars, dhaumann
D12768: Allow wrapping selection off top/bottom of autocomplete results
sraizada added a project: KTextEditor. sraizada added a subscriber: KTextEditor. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D12768 To: sraizada, #ktexteditor Cc: #ktexteditor, #frameworks, michaelh, kevinapavew, ngraham, bruns, demsking, head7, cullmann, kfunk, sars, dhaumann
D12768: Allow wrapping selection off top/bottom of autocomplete results
sraizada created this revision. sraizada added a reviewer: KTextEditor. Restricted Application added projects: Kate, Frameworks. Restricted Application added a subscriber: Frameworks. sraizada requested review of this revision. REVISION SUMMARY When at the first autocomplete result, pressing up will wrap around to the last result, and vice versa. This does make test 56 (completion_test) fail with an "Exception: Child aborted" - I'm looking into it. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D12768 AFFECTED FILES src/completion/katecompletiontree.cpp To: sraizada, #ktexteditor Cc: #frameworks, michaelh, kevinapavew, ngraham, bruns, demsking, cullmann, sars, dhaumann
