D13026: Open Schema toolbar button with normal click rather than click-and-hold

2018-06-09 Thread Nathaniel Graham 
ngraham updated this revision to Diff 35890.
ngraham added a comment.


  Also make this change for all other toolButtons that open menus

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13026?vs=34604&id=35890

BRANCH
  schema-toolbar-button-opens-on-normal-click (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D13026

AFFECTED FILES
  src/mode/katemodemenu.h
  src/schema/kateschema.h
  src/script/katescriptaction.cpp
  src/syntax/katehighlightmenu.h
  src/utils/kateautoindent.cpp
  src/utils/katebookmarks.cpp

To: ngraham, #ktexteditor, #kate, dhaumann, cullmann
Cc: hpereiradacosta, kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D13026: Open Schema toolbar button with normal click rather than click-and-hold

2018-06-09 Thread Nathaniel Graham 
ngraham planned changes to this revision.
ngraham added a comment.


  I don't think being `delayed` was a deliberate choice; it's simply the 
default interaction method for toolbuttons that open menus in Qt (for some odd 
reason). Every menu toolbutton throughout KDE software that shows its menu 
instantly does `setDelayed(false);`, and I've never seen the menu have to 
visually build itself while open.
  
  Let me handle those other cases with this patch, too.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D13026

To: ngraham, #ktexteditor, #kate, dhaumann, cullmann
Cc: hpereiradacosta, kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D13026: Open Schema toolbar button with normal click rather than click-and-hold

2018-06-09 Thread Dominik Haumann 
dhaumann added a comment.


  The same holds true for other actions such as: Tools > Highlighting, Mode, 
Indentation, Script.
  
  Question here is: Is this delayed thing needed for building the contents 
on-the-fly (look at the aboutToShow() functions)?

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D13026

To: ngraham, #ktexteditor, #kate, dhaumann, cullmann
Cc: hpereiradacosta, kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D13026: Open Schema toolbar button with normal click rather than click-and-hold

2018-05-31 Thread Nathaniel Graham 
ngraham edited the summary of this revision.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D13026

To: ngraham, #ktexteditor, #kate, dhaumann, cullmann
Cc: hpereiradacosta, kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D13026: Open Schema toolbar button with normal click rather than click-and-hold

2018-05-31 Thread Nathaniel Graham 
ngraham added reviewers: dhaumann, cullmann.
ngraham added a comment.


  Friendly ping!

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D13026

To: ngraham, #ktexteditor, #kate, dhaumann, cullmann
Cc: hpereiradacosta, kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D13026: Open Schema toolbar button with normal click rather than click-and-hold

2018-05-25 Thread Nathaniel Graham 
ngraham added a comment.


  Fair enough!

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D13026

To: ngraham, #ktexteditor, #kate
Cc: hpereiradacosta, kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D13026: Open Schema toolbar button with normal click rather than click-and-hold

2018-05-25 Thread Nathaniel Graham 
ngraham edited the summary of this revision.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D13026

To: ngraham, #ktexteditor, #kate
Cc: hpereiradacosta, kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D13026: Open Schema toolbar button with normal click rather than click-and-hold

2018-05-25 Thread Hugo Pereira Da Costa 
hpereiradacosta added a comment.


  Hello, 
  I would appreciate that you rephrase the description for this patch (and 
others where the same comment appear):  the dissapearing arrow with breeze is 
not a *bug* in breeze, but a (conscious) design choice, that is discussed in  
D13064  and in the bug attached.  D13064 
 is not fixing that bug, it is a proposal 
to revert that design choice.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D13026

To: ngraham, #ktexteditor, #kate
Cc: hpereiradacosta, kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D13026: Open Schema toolbar button with normal click rather than click-and-hold

2018-05-25 Thread Nathaniel Graham 
ngraham added a comment.


  Friendly ping!

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D13026

To: ngraham, #ktexteditor, #kate
Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D13026: Open Schema toolbar button with normal click rather than click-and-hold

2018-05-25 Thread Nathaniel Graham 
ngraham edited the summary of this revision.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D13026

To: ngraham, #ktexteditor, #kate
Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D13026: Open Schema toolbar button with normal click rather than click-and-hold

2018-05-21 Thread Nathaniel Graham 
ngraham created this revision.
ngraham added reviewers: KTextEditor, Kate.
Restricted Application added projects: Kate, Frameworks.
Restricted Application added subscribers: kde-frameworks-devel, kwrite-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  Fixes Kate/KWrite's Schema menu when added as toolbar button so that it open 
shows the drop-down menu immediately when clicked instead of requiring a 
click-and-hold.
  
  Note: this also has the effect of removing the downward-pointing arrow that 
lets you know that the toolbar button will open a menu, but that's a bug in 
Breeze: https://bugs.kde.org/show_bug.cgi?id=344746
  
  BUG: 353747
  FIXED-IN: 5.47

TEST PLAN
  Added Schema button to Kate and clicked it. It opened immediately.

REPOSITORY
  R39 KTextEditor

BRANCH
  schema-toolbar-button-opens-on-normal-click (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D13026

AFFECTED FILES
  src/schema/kateschema.h

To: ngraham, #ktexteditor, #kate
Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, 
demsking, cullmann, sars, dhaumann