D13117: Don't set custom domain filter rules

2018-05-25 Thread Aleksander Morgado 
aleksanderm created this revision.
aleksanderm added reviewers: jgrulich, broulik.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: kde-frameworks-devel.
aleksanderm requested review of this revision.

REVISION SUMMARY
  The library shouldn't set custom filter rules, it's a task of the app
  using the library to enable or disable them.

REPOSITORY
  R281 ModemManagerQt

BRANCH
  fix-logging

REVISION DETAIL
  https://phabricator.kde.org/D13117

AFFECTED FILES
  src/manager.cpp

To: aleksanderm, jgrulich, broulik
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13117: Don't set custom domain filter rules

2018-05-25 Thread Aleksander Morgado 
aleksanderm added a reviewer: Frameworks.

REPOSITORY
  R281 ModemManagerQt

REVISION DETAIL
  https://phabricator.kde.org/D13117

To: aleksanderm, jgrulich, broulik, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13117: Don't set custom domain filter rules

2018-05-26 Thread Jan Grulich 
jgrulich accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R281 ModemManagerQt

BRANCH
  fix-logging

REVISION DETAIL
  https://phabricator.kde.org/D13117

To: aleksanderm, jgrulich, broulik, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13117: Don't set custom domain filter rules

2018-06-11 Thread Aleksander Morgado 
aleksanderm added a comment.


  Any ETA to land this change?

REPOSITORY
  R281 ModemManagerQt

BRANCH
  fix-logging

REVISION DETAIL
  https://phabricator.kde.org/D13117

To: aleksanderm, jgrulich, broulik, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13117: Don't set custom domain filter rules

2018-06-12 Thread Jan Grulich 
This revision was automatically updated to reflect the committed changes.
Closed by commit R281:54cc344aa659: Don't set custom domain filter rules 
(authored by aleksanderm, committed by jgrulich).

REPOSITORY
  R281 ModemManagerQt

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13117?vs=34870&id=36036

REVISION DETAIL
  https://phabricator.kde.org/D13117

AFFECTED FILES
  src/manager.cpp

To: aleksanderm, jgrulich, broulik, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns