D13150: Add ellipsis where appropriate

[Nicolas Fella]

This revision was automatically updated to reflect the committed changes.
Closed by commit R495:2eb66cbd8666: Add ellipsis where appropriate (authored by 
nicolasfella).

REPOSITORY
  R495 Purpose Library

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13150?vs=60441&id=60445

REVISION DETAIL
  https://phabricator.kde.org/D13150

AFFECTED FILES
  extraJsonTranslationKeys.txt
  src/alternativesmodel.cpp
  src/alternativesmodel.h
  src/plugins/bluetooth/bluetoothplugin.json
  src/plugins/email/emailplugin.json
  src/plugins/imgur/imgurplugin.json
  src/plugins/kdeconnect/kdeconnectplugin.json
  src/plugins/kdeconnect_sms/kdeconnectsmsplugin.json
  src/plugins/ktp-sendfile/ktpsendfileplugin.json
  src/plugins/nextcloud/nextcloudplugin.json
  src/plugins/pastebin/pastebinplugin.json
  src/plugins/phabricator/phabricatorplugin.json
  src/plugins/reviewboard/reviewboardplugin.json
  src/plugins/saveas/saveasplugin.json
  src/plugins/telegram/telegramplugin.json
  src/plugins/twitter/metadata.json
  src/plugins/youtube/youtubeplugin.json
  src/widgets/menu.cpp

To: nicolasfella, #vdg, apol, ngraham
Cc: aspotashev, apol, kde-frameworks-devel, #vdg, LeGast00n, michaelh, ngraham, 
bruns

D13150: Add ellipsis where appropriate

[Aleix Pol Gonzalez]

apol accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R495 Purpose Library

BRANCH
  ellipsis

REVISION DETAIL
  https://phabricator.kde.org/D13150

To: nicolasfella, #vdg, apol, ngraham
Cc: aspotashev, apol, kde-frameworks-devel, #vdg, LeGast00n, michaelh, ngraham, 
bruns

D13150: Add ellipsis where appropriate

[Nicolas Fella]

nicolasfella updated this revision to Diff 60441.
nicolasfella added a comment.


  - rename role
  - add file for extra translations

REPOSITORY
  R495 Purpose Library

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13150?vs=60346&id=60441

BRANCH
  ellipsis

REVISION DETAIL
  https://phabricator.kde.org/D13150

AFFECTED FILES
  extraJsonTranslationKeys.txt
  src/alternativesmodel.cpp
  src/alternativesmodel.h
  src/plugins/bluetooth/bluetoothplugin.json
  src/plugins/email/emailplugin.json
  src/plugins/imgur/imgurplugin.json
  src/plugins/kdeconnect/kdeconnectplugin.json
  src/plugins/kdeconnect_sms/kdeconnectsmsplugin.json
  src/plugins/ktp-sendfile/ktpsendfileplugin.json
  src/plugins/nextcloud/nextcloudplugin.json
  src/plugins/pastebin/pastebinplugin.json
  src/plugins/phabricator/phabricatorplugin.json
  src/plugins/reviewboard/reviewboardplugin.json
  src/plugins/saveas/saveasplugin.json
  src/plugins/telegram/telegramplugin.json
  src/plugins/twitter/metadata.json
  src/plugins/youtube/youtubeplugin.json
  src/widgets/menu.cpp

To: nicolasfella, #vdg, apol, ngraham
Cc: aspotashev, apol, kde-frameworks-devel, #vdg, LeGast00n, michaelh, ngraham, 
bruns

D13150: Add ellipsis where appropriate

[Aleix Pol Gonzalez]

apol added a comment.


  X-Purpose-Action won't get translations.

REPOSITORY
  R495 Purpose Library

REVISION DETAIL
  https://phabricator.kde.org/D13150

To: nicolasfella, #vdg, apol, ngraham
Cc: aspotashev, apol, kde-frameworks-devel, #vdg, LeGast00n, michaelh, ngraham, 
bruns

D13150: Add ellipsis where appropriate

[Nathaniel Graham]

ngraham accepted this revision.

REPOSITORY
  R495 Purpose Library

REVISION DETAIL
  https://phabricator.kde.org/D13150

To: nicolasfella, #vdg, apol, ngraham
Cc: aspotashev, apol, kde-frameworks-devel, #vdg, LeGast00n, michaelh, ngraham, 
bruns

D13150: Add ellipsis where appropriate

[Nicolas Fella]

nicolasfella updated this revision to Diff 60346.
nicolasfella added a comment.


  - fall back to name

REPOSITORY
  R495 Purpose Library

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13150?vs=60341&id=60346

BRANCH
  ellipsis

REVISION DETAIL
  https://phabricator.kde.org/D13150

AFFECTED FILES
  src/alternativesmodel.cpp
  src/alternativesmodel.h
  src/plugins/bluetooth/bluetoothplugin.json
  src/plugins/email/emailplugin.json
  src/plugins/imgur/imgurplugin.json
  src/plugins/kdeconnect/kdeconnectplugin.json
  src/plugins/kdeconnect_sms/kdeconnectsmsplugin.json
  src/plugins/ktp-sendfile/ktpsendfileplugin.json
  src/plugins/nextcloud/nextcloudplugin.json
  src/plugins/pastebin/pastebinplugin.json
  src/plugins/phabricator/phabricatorplugin.json
  src/plugins/reviewboard/reviewboardplugin.json
  src/plugins/saveas/saveasplugin.json
  src/plugins/telegram/telegramplugin.json
  src/plugins/twitter/metadata.json
  src/plugins/youtube/youtubeplugin.json
  src/widgets/menu.cpp

To: nicolasfella, #vdg, apol, ngraham
Cc: aspotashev, apol, kde-frameworks-devel, #vdg, LeGast00n, michaelh, ngraham, 
bruns

D13150: Add ellipsis where appropriate

[Alexander Potashev]

aspotashev added a comment.


  We probably need to fall back to "%1..." if X-Purpose-Action is not defined, 
which is possible for 3rd-party plugins.

REPOSITORY
  R495 Purpose Library

REVISION DETAIL
  https://phabricator.kde.org/D13150

To: nicolasfella, #vdg, apol, ngraham
Cc: aspotashev, apol, kde-frameworks-devel, #vdg, LeGast00n, michaelh, ngraham, 
bruns

D13150: Add ellipsis where appropriate

[Nathaniel Graham]

ngraham added a comment.


  Looks like a couple of strings are now blank: F6923766: 
Screenshot_20190622_150439.png 

REPOSITORY
  R495 Purpose Library

REVISION DETAIL
  https://phabricator.kde.org/D13150

To: nicolasfella, #vdg, apol, ngraham
Cc: aspotashev, apol, kde-frameworks-devel, #vdg, LeGast00n, michaelh, ngraham, 
bruns

D13150: Add ellipsis where appropriate

[Nicolas Fella]

nicolasfella added a comment.


  This resolves the issue that the name with ellipsis shows up in the dialog 
title

REPOSITORY
  R495 Purpose Library

REVISION DETAIL
  https://phabricator.kde.org/D13150

To: nicolasfella, #vdg, apol, ngraham
Cc: aspotashev, apol, kde-frameworks-devel, #vdg, LeGast00n, michaelh, ngraham, 
bruns

D13150: Add ellipsis where appropriate

[Nicolas Fella]

nicolasfella requested review of this revision.

REPOSITORY
  R495 Purpose Library

REVISION DETAIL
  https://phabricator.kde.org/D13150

To: nicolasfella, #vdg, apol, ngraham
Cc: aspotashev, apol, kde-frameworks-devel, #vdg, LeGast00n, michaelh, ngraham, 
bruns

D13150: Add ellipsis where appropriate

[Nicolas Fella]

nicolasfella planned changes to this revision.

REPOSITORY
  R495 Purpose Library

REVISION DETAIL
  https://phabricator.kde.org/D13150

To: nicolasfella, #vdg, apol, ngraham
Cc: aspotashev, apol, kde-frameworks-devel, #vdg, LeGast00n, michaelh, ngraham, 
bruns

D13150: Add ellipsis where appropriate

[Nicolas Fella]

nicolasfella updated this revision to Diff 60341.
nicolasfella added a comment.


  Implement Alexander's suggestion

REPOSITORY
  R495 Purpose Library

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13150?vs=53551&id=60341

BRANCH
  ellipsis

REVISION DETAIL
  https://phabricator.kde.org/D13150

AFFECTED FILES
  src/alternativesmodel.cpp
  src/alternativesmodel.h
  src/plugins/bluetooth/bluetoothplugin.json
  src/plugins/email/emailplugin.json
  src/plugins/imgur/imgurplugin.json
  src/plugins/kdeconnect/kdeconnectplugin.json
  src/plugins/kdeconnect_sms/kdeconnectsmsplugin.json
  src/plugins/ktp-sendfile/ktpsendfileplugin.json
  src/plugins/nextcloud/nextcloudplugin.json
  src/plugins/pastebin/pastebinplugin.json
  src/plugins/phabricator/phabricatorplugin.json
  src/plugins/reviewboard/reviewboardplugin.json
  src/plugins/saveas/saveasplugin.json
  src/plugins/telegram/telegramplugin.json
  src/plugins/twitter/metadata.json
  src/plugins/youtube/youtubeplugin.json
  src/widgets/menu.cpp

To: nicolasfella, #vdg, apol, ngraham
Cc: aspotashev, apol, kde-frameworks-devel, #vdg, LeGast00n, michaelh, ngraham, 
bruns

D13150: Add ellipsis where appropriate

[Alexander Potashev]

aspotashev added a comment.


  In D13150#428167 , @ngraham wrote:
  
  > This results in every item in the menu getting an ellipsis, which isn't 
appropriate because not all of them require more user action to proceed (the 
imgur plugin is one such example). It seems like we need a way to indicate in 
the desktop file that the plugin will require user interaction and need an 
ellipsis displayed in the UI, without hardcoding that information with an 
ellipsis in the plugin's own name.
  
  
  This sounds like a hack as well. I think we need another translatable field 
in JSON, independent from "Name".
  
  Here is a similar problem with KIO: 
https://bugs.kde.org/show_bug.cgi?id=243287

REPOSITORY
  R495 Purpose Library

REVISION DETAIL
  https://phabricator.kde.org/D13150

To: nicolasfella, #vdg, apol, ngraham
Cc: aspotashev, apol, kde-frameworks-devel, #vdg, michaelh, ngraham, bruns

D13150: Add ellipsis where appropriate

[Nathaniel Graham]

ngraham requested changes to this revision.
ngraham added a comment.
This revision now requires changes to proceed.


  This results in every item in the menu getting an ellipsis, which isn't 
appropriate because not all of them require more user action to proceed (the 
imgur plugin is one such example). It seems like we need a way to indicate in 
the desktop file that the plugin will require user interaction and need an 
ellipsis displayed in the UI, without hardcoding that information with an 
ellipsis in the plugin's own name.

REPOSITORY
  R495 Purpose Library

REVISION DETAIL
  https://phabricator.kde.org/D13150

To: nicolasfella, #vdg, apol, ngraham
Cc: apol, kde-frameworks-devel, #vdg, michaelh, ngraham, bruns

D13150: Add ellipsis where appropriate

[Nicolas Fella]

nicolasfella updated this revision to Diff 53551.
nicolasfella added a comment.


  - Use i18n

REPOSITORY
  R495 Purpose Library

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13150?vs=53550&id=53551

BRANCH
  ellipsis

REVISION DETAIL
  https://phabricator.kde.org/D13150

AFFECTED FILES
  src/plugins/bluetooth/bluetoothplugin.json
  src/plugins/email/emailplugin.json
  src/plugins/kdeconnect/kdeconnectplugin.json
  src/plugins/ktp-sendfile/ktpsendfileplugin.json
  src/plugins/saveas/saveasplugin.json
  src/plugins/telegram/telegramplugin.json
  src/widgets/menu.cpp

To: nicolasfella, #vdg, apol, ngraham
Cc: apol, kde-frameworks-devel, #vdg, michaelh, ngraham, bruns

D13150: Add ellipsis where appropriate

[Nicolas Fella]

nicolasfella updated this revision to Diff 53550.
nicolasfella added a comment.


  Move ellipsis from plugin name to menu

REPOSITORY
  R495 Purpose Library

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13150?vs=34975&id=53550

BRANCH
  ellipsis

REVISION DETAIL
  https://phabricator.kde.org/D13150

AFFECTED FILES
  src/plugins/bluetooth/bluetoothplugin.json
  src/plugins/email/emailplugin.json
  src/plugins/kdeconnect/kdeconnectplugin.json
  src/plugins/ktp-sendfile/ktpsendfileplugin.json
  src/plugins/saveas/saveasplugin.json
  src/plugins/telegram/telegramplugin.json
  src/widgets/menu.cpp

To: nicolasfella, #vdg, apol, ngraham
Cc: apol, kde-frameworks-devel, #vdg, michaelh, ngraham, bruns

D13150: Add ellipsis where appropriate

[Nicolas Fella]

nicolasfella added a comment.


  Quote from VDG:
  If there will be further user input needed and a dialogue or similar popping 
up for it: needs ellipsis
  
  Therefore Pastebin would not need one, but I guess this is neglectable

REPOSITORY
  R495 Purpose Library

REVISION DETAIL
  https://phabricator.kde.org/D13150

To: nicolasfella, #vdg, apol, ngraham
Cc: apol, kde-frameworks-devel, #vdg, michaelh, ngraham, bruns

D13150: Add ellipsis where appropriate

[Aleix Pol Gonzalez]

apol added a comment.


  In D13150#269388 , @nicolasfella 
wrote:
  
  > It's done this way in Email, KTP and KDE Connect already. If we add the 
ellipsis in AlternativesModel's DisplayRole we get it on every entry, even if 
it would be inappropriate.
  
  
  In which cases would it be inappropriate?

REPOSITORY
  R495 Purpose Library

REVISION DETAIL
  https://phabricator.kde.org/D13150

To: nicolasfella, #vdg, apol, ngraham
Cc: apol, kde-frameworks-devel, #vdg, michaelh, ngraham, bruns

D13150: Add ellipsis where appropriate

[Nicolas Fella]

nicolasfella added a comment.


  It's done this way in Email, KTP and KDE Connect already. If we add the 
ellipsis in AlternativesModel's DisplayRole we get it on every entry, even if 
it would be inappropriate.

REPOSITORY
  R495 Purpose Library

REVISION DETAIL
  https://phabricator.kde.org/D13150

To: nicolasfella, #vdg, apol, ngraham
Cc: apol, kde-frameworks-devel, #vdg, michaelh, ngraham, bruns

D13150: Add ellipsis where appropriate

[Aleix Pol Gonzalez]

apol requested changes to this revision.
apol added a comment.
This revision now requires changes to proceed.


  That's not correct. This is the plugin name. If you want elipsis add it onto 
the model's displayrole.

REPOSITORY
  R495 Purpose Library

REVISION DETAIL
  https://phabricator.kde.org/D13150

To: nicolasfella, #vdg, apol, ngraham
Cc: apol, kde-frameworks-devel, #vdg, michaelh, ngraham, bruns

D13150: Add ellipsis where appropriate

[Nathaniel Graham]

ngraham accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R495 Purpose Library

BRANCH
  ellipsis

REVISION DETAIL
  https://phabricator.kde.org/D13150

To: nicolasfella, #vdg, apol, ngraham
Cc: apol, kde-frameworks-devel, #vdg, michaelh, ngraham, bruns

D13150: Add ellipsis where appropriate

[Nicolas Fella]

nicolasfella created this revision.
nicolasfella added reviewers: VDG, apol.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: kde-frameworks-devel.
nicolasfella requested review of this revision.

REVISION SUMMARY
  Add ellipsis to actions that open up a dialog. It doesn't seem to work for 
Twitter, probably because it's different to the other plugins.

REPOSITORY
  R495 Purpose Library

BRANCH
  ellipsis

REVISION DETAIL
  https://phabricator.kde.org/D13150

AFFECTED FILES
  src/plugins/nextcloud/nextcloudplugin.json
  src/plugins/phabricator/phabricatorplugin.json
  src/plugins/reviewboard/reviewboardplugin.json
  src/plugins/twitter/metadata.json

To: nicolasfella, #vdg, apol
Cc: apol, kde-frameworks-devel, #vdg, michaelh, ngraham, bruns