D13495: Fix XDGV6 popup test

2018-06-22 Thread David Edmundson 
This revision was automatically updated to reflect the committed changes.
Closed by commit R127:64ce88d4fc3d: Fix XDGV6 popup test (authored by 
davidedmundson).

REPOSITORY
  R127 KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13495?vs=36051=36511

REVISION DETAIL
  https://phabricator.kde.org/D13495

AFFECTED FILES
  autotests/client/test_xdg_shell_v6.cpp

To: davidedmundson, #kwin, mart
Cc: romangg, kde-frameworks-devel, michaelh, ngraham, bruns

D13495: Fix XDGV6 popup test

2018-06-22 Thread Marco Martin 
mart accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D13495

To: davidedmundson, #kwin, mart
Cc: romangg, kde-frameworks-devel, michaelh, ngraham, bruns

D13495: Fix XDGV6 popup test

2018-06-19 Thread David Edmundson 
davidedmundson added a dependent revision: D13530: Add XDG WmBase support.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D13495

To: davidedmundson, #kwin
Cc: romangg, kde-frameworks-devel, michaelh, ngraham, bruns

D13495: Fix XDGV6 popup test

2018-06-14 Thread David Edmundson 
davidedmundson added a comment.


  You can only set the size in the ctor, so needed a new instance.
  
  For the rest of the tests we don't need different sizes.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D13495

To: davidedmundson, #kwin
Cc: romangg, kde-frameworks-devel, michaelh, ngraham, bruns

D13495: Fix XDGV6 popup test

2018-06-14 Thread Roman Gilg 
romangg added a comment.


  What's with positioner2?

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D13495

To: davidedmundson, #kwin
Cc: romangg, kde-frameworks-devel, michaelh, ngraham, bruns

D13495: Fix XDGV6 popup test

2018-06-12 Thread David Edmundson 
davidedmundson created this revision.
davidedmundson added a reviewer: KWin.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: kde-frameworks-devel.
davidedmundson requested review of this revision.

REVISION SUMMARY
  We had a data funciton...then didn't use it, effectively skpping half of
  the point of the test.

TEST PLAN
  Ran the test

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D13495

AFFECTED FILES
  autotests/client/test_xdg_shell_v6.cpp

To: davidedmundson, #kwin
Cc: kde-frameworks-devel, michaelh, ngraham, bruns