D13643: Add LabPlot project file icon

2018-08-25 Thread Nathaniel Graham 
ngraham added a comment.


  Thanks again for your contribution! Next time, we'll try to be more on the 
ball about the review. :)

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D13643

To: mtrescott, #labplot, #vdg, #breeze, ngraham
Cc: abetts, asemke, ngraham, kde-frameworks-devel, michaelh, bruns

D13643: Add LabPlot project file icon

2018-08-25 Thread Nathaniel Graham 
ngraham closed this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D13643

To: mtrescott, #labplot, #vdg, #breeze, ngraham
Cc: abetts, asemke, ngraham, kde-frameworks-devel, michaelh, bruns

D13643: Add LabPlot project file icon

2018-08-25 Thread Matthew Trescott 
mtrescott added a comment.


  Sure.
  Real name: Matthew Trescott
  Email: matthewtresc...@gmail.com

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D13643

To: mtrescott, #labplot, #vdg, #breeze, ngraham
Cc: abetts, asemke, ngraham, kde-frameworks-devel, michaelh, bruns

D13643: Add LabPlot project file icon

2018-08-25 Thread Nathaniel Graham 
ngraham added a comment.


  Whoops, sorry this was missed. I can merge it for you, since it looks great! 
In order to do this, I'll need to know your real name and preferred email 
address. Can you tell me those?

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D13643

To: mtrescott, #labplot, #vdg, #breeze, ngraham
Cc: abetts, asemke, ngraham, kde-frameworks-devel, michaelh, bruns

D13643: Add LabPlot project file icon

2018-08-25 Thread Matthew Trescott 
mtrescott added a comment.


  Bump. Please, can someone merge this? For all that I read on Planet KDE about 
"streamlined onboarding of contributors" nothing has happened here.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D13643

To: mtrescott, #labplot, #vdg, #breeze, ngraham
Cc: abetts, asemke, ngraham, kde-frameworks-devel, michaelh, bruns

D13643: Add LabPlot project file icon

2018-08-16 Thread Matthew Trescott 
mtrescott added a comment.


  Bump

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D13643

To: mtrescott, #labplot, #vdg, #breeze, ngraham
Cc: abetts, asemke, ngraham, kde-frameworks-devel, michaelh, bruns

D13643: Add LabPlot project file icon

2018-07-01 Thread Nathaniel Graham 
ngraham accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D13643

To: mtrescott, #labplot, #vdg, #breeze, ngraham
Cc: abetts, asemke, ngraham, kde-frameworks-devel, michaelh, bruns

D13643: Add LabPlot project file icon

2018-07-01 Thread Andres Betts 
abetts added a comment.


  Oh great! I thought the team was looking for a logo. Then, I have nothing 
more to add. It looks great.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D13643

To: mtrescott, #labplot, #vdg, #breeze
Cc: abetts, asemke, ngraham, kde-frameworks-devel, michaelh, bruns

D13643: Add LabPlot project file icon

2018-07-01 Thread Nathaniel Graham 
ngraham added a comment.


  In D13643#285745 , @abetts wrote:
  
  > My first impression is that it looks a lot like a file emblem. I would 
probably remove the background and keep only the logo.
  
  
  But it //is// a file icon...
  
  Typically the way these are done with the Breeze icon theme is that the small 
size shows only the icon, while the larger size uses a generic colored document 
icon with the app's icon or else some other symbolic icon in the center.
  
  I think this looks great!

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D13643

To: mtrescott, #labplot, #vdg, #breeze
Cc: abetts, asemke, ngraham, kde-frameworks-devel, michaelh, bruns

D13643: Add LabPlot project file icon

2018-07-01 Thread Andres Betts 
abetts added a comment.


  My first impression is that it looks a lot like a file emblem. I would 
probably remove the background and keep only the logo.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D13643

To: mtrescott, #labplot, #vdg, #breeze
Cc: abetts, asemke, ngraham, kde-frameworks-devel, michaelh, bruns

D13643: Add LabPlot project file icon

2018-07-01 Thread Alexander Semke 
asemke added a comment.


  Thank for this work. It looks nice to me. However, maybe it's better for 
people from VDG and Breeze teams to accept this or to raise objections.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D13643

To: mtrescott, #labplot, #vdg, #breeze
Cc: asemke, ngraham, kde-frameworks-devel, michaelh, bruns

D13643: Add LabPlot project file icon

2018-06-21 Thread Matthew Trescott 
mtrescott edited the summary of this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D13643

To: mtrescott, #labplot, #vdg, #breeze
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D13643: Add LabPlot project file icon

2018-06-21 Thread Matthew Trescott 
mtrescott added a comment.


  @ngraham I edited it to have a screenshot.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D13643

To: mtrescott, #labplot, #vdg, #breeze
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D13643: Add LabPlot project file icon

2018-06-21 Thread Matthew Trescott 
mtrescott edited the summary of this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D13643

To: mtrescott, #labplot, #vdg, #breeze
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D13643: Add LabPlot project file icon

2018-06-21 Thread Nathaniel Graham 
ngraham added a comment.


  Icon patches always need screenshots! :)

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D13643

To: mtrescott, #labplot, #vdg, #breeze
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D13643: Add LabPlot project file icon

2018-06-20 Thread Matthew Trescott 
mtrescott created this revision.
mtrescott added reviewers: LabPlot, VDG, Breeze.
mtrescott added a project: Breeze.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: kde-frameworks-devel.
mtrescott requested review of this revision.

REVISION SUMMARY
  Rather than simply displaying the gzip icon, Breeze should include a nice 
icon for LabPlot files.

TEST PLAN
  - Make sure the icon is easy enough to understand

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D13643

AFFECTED FILES
  icons/mimetypes/64/application-x-labplot2.svg

To: mtrescott, #labplot, #vdg, #breeze
Cc: kde-frameworks-devel, michaelh, ngraham, bruns