D13729: Isolate every test within WaylandOutputManagement
This revision was automatically updated to reflect the committed changes. Closed by commit R127:d6a250cfb16b: Isolate every test within WaylandOutputManagement (authored by davidedmundson). REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13729?vs=36662=39132 REVISION DETAIL https://phabricator.kde.org/D13729 AFFECTED FILES autotests/client/test_wayland_outputmanagement.cpp To: davidedmundson, #kwin, romangg Cc: romangg, kde-frameworks-devel, michaelh, ngraham, bruns
D13729: Isolate every test within WaylandOutputManagement
romangg accepted this revision. romangg added a comment. This revision is now accepted and ready to land. There is no reason to use the member variable `m_outputConfiguration` and the method `createConfig` anymore. Just use a scoped pointer in the tests you need it. But we can leave it like this as well. Other inline comments are up to you. INLINE COMMENTS > test_wayland_outputmanagement.cpp:68 > private: > +void createOutputDevices(); > void testEnable(); > -void applyPendingChanges(); Btw as a private method this test is not performed at all. > test_wayland_outputmanagement.cpp:180 > + > +m_registry->create(m_connection->display()); > +QVERIFY(m_registry->isValid()); `m_registry->create(m_connection);` > test_wayland_outputmanagement.cpp:184 > +m_registry->setup(); > +wl_display_flush(m_connection->display()); > + `m_connection->flush();` > test_wayland_outputmanagement.cpp:476 > QVERIFY(configAppliedSpy.wait(200)); > + > } rm new line > test_wayland_outputmanagement.cpp:512 > > + > QTEST_GUILESS_MAIN(TestWaylandOutputManagement) rm new line REPOSITORY R127 KWayland BRANCH davidedmundson/scalef REVISION DETAIL https://phabricator.kde.org/D13729 To: davidedmundson, #kwin, romangg Cc: romangg, kde-frameworks-devel, michaelh, ngraham, bruns
D13729: Isolate every test within WaylandOutputManagement
davidedmundson created this revision. davidedmundson added a reviewer: KWin. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. davidedmundson requested review of this revision. REVISION SUMMARY The current code used the same outputInterface between all tests, with data and outdated connections slowly accumulating. This meant most the code didn't work as it was intended, for example testExampleConfig had the config applied from the connect in the previous test. It just happened to pass. This resets everything between each test. TEST PLAN Can now add a test without going insane Existing tests still pass REPOSITORY R127 KWayland BRANCH davidedmundson/scalef REVISION DETAIL https://phabricator.kde.org/D13729 AFFECTED FILES autotests/client/test_wayland_outputmanagement.cpp To: davidedmundson, #kwin Cc: kde-frameworks-devel, michaelh, ngraham, bruns
