D13892: Restore compatibility of UDS::insert

2018-07-05 Thread Jaime Torres Amate 
This revision was automatically updated to reflect the committed changes.
Closed by commit R241:8cd6be0b1c09: Restore compatibility of UDS::insert 
(authored by jtamate).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13892?vs=37170=37198

REVISION DETAIL
  https://phabricator.kde.org/D13892

AFFECTED FILES
  src/core/udsentry.cpp
  src/core/udsentry.h

To: jtamate, dfaure, #frameworks, aacid
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13892: Restore compatibility of UDS::insert

2018-07-05 Thread David Faure 
dfaure accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D13892

To: jtamate, dfaure, #frameworks, aacid
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13892: Restore compatibility of UDS::insert

2018-07-05 Thread Jaime Torres Amate 
jtamate updated this revision to Diff 37170.
jtamate marked 2 inline comments as done.
jtamate added a comment.


  Added KIOCORE_DEPRECATED

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13892?vs=37163=37170

REVISION DETAIL
  https://phabricator.kde.org/D13892

AFFECTED FILES
  src/core/udsentry.cpp
  src/core/udsentry.h

To: jtamate, dfaure, #frameworks, aacid
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13892: Restore compatibility of UDS::insert

2018-07-04 Thread David Faure 
dfaure added inline comments.

INLINE COMMENTS

> udsentry.h:148
>   */
>  void insert(uint field, const QString );
>  

KIOCORE_DEPRECATED void...

> udsentry.h:156
>   */
>  void insert(uint field, long long l);
>  

KIOCORE_DEPRECATED void...

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D13892

To: jtamate, dfaure, #frameworks, aacid
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13892: Restore compatibility of UDS::insert

2018-07-04 Thread Jaime Torres Amate 
jtamate updated this revision to Diff 37163.
jtamate added a comment.


  Now better.

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13892?vs=37161=37163

REVISION DETAIL
  https://phabricator.kde.org/D13892

AFFECTED FILES
  src/core/udsentry.cpp
  src/core/udsentry.h

To: jtamate, dfaure, #frameworks, aacid
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13892: Restore compatibility of UDS::insert

2018-07-04 Thread Jaime Torres Amate 
jtamate created this revision.
jtamate added reviewers: dfaure, Frameworks, aacid.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: kde-frameworks-devel.
jtamate requested review of this revision.

REVISION SUMMARY
  Restore KIO backwards compatibility

TEST PLAN
  kio tests passes

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D13892

AFFECTED FILES
  src/core/udsentry.cpp
  src/core/udsentry.h

To: jtamate, dfaure, #frameworks, aacid
Cc: kde-frameworks-devel, michaelh, ngraham, bruns