D13895: Fix off by one error in Cache::clear

2018-07-05 Thread David Edmundson 
This revision was automatically updated to reflect the committed changes.
Closed by commit R159:3d81d0b314f5: Fix off by one error in Cache::clear 
(authored by davidedmundson).

REPOSITORY
  R159 KActivities Statistics

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13895?vs=37167&id=37180

REVISION DETAIL
  https://phabricator.kde.org/D13895

AFFECTED FILES
  src/resultmodel.cpp

To: davidedmundson, broulik
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13895: Fix off by one error in Cache::clear

2018-07-05 Thread Kai Uwe Broulik 
broulik accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R159 KActivities Statistics

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D13895

To: davidedmundson, broulik
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13895: Fix off by one error in Cache::clear

2018-07-04 Thread David Edmundson 
davidedmundson created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: kde-frameworks-devel.
davidedmundson requested review of this revision.

REVISION SUMMARY
  beginRemoveRows args are int first, int last
  
  i.e If you have 1 entry you should be calling
  beginRemoveRows(0, 0);
  
  BUG: 396175

TEST PLAN
  Code review of a common mistake
  Other usages in the same code were fine

REPOSITORY
  R159 KActivities Statistics

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D13895

AFFECTED FILES
  src/resultmodel.cpp

To: davidedmundson
Cc: kde-frameworks-devel, michaelh, ngraham, bruns