D13921: Don't show confirmation dialog for Trash action by default

[Алексей Шилин]

This revision was automatically updated to reflect the committed changes.
Closed by commit R241:7d15dad5e427: Don't show confirmation dialog for 
Trash action by default (authored by aleksejshilin).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13921?vs=37242&id=37441

REVISION DETAIL
  https://phabricator.kde.org/D13921

AFFECTED FILES
  src/widgets/jobuidelegate.cpp

To: aleksejshilin, dfaure, #frameworks, #dolphin, ngraham
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D13921: Don't show confirmation dialog for Trash action by default

[Алексей Шилин]

aleksejshilin edited the summary of this revision.

REPOSITORY
  R241 KIO

BRANCH
  dont_confirm_trash

REVISION DETAIL
  https://phabricator.kde.org/D13921

To: aleksejshilin, dfaure, #frameworks, #dolphin, ngraham
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D13921: Don't show confirmation dialog for Trash action by default

[Алексей Шилин]

aleksejshilin added a comment.


  In D13921#288012 , @ngraham wrote:
  
  > There's a problem with the git setup on the computer you used to make this 
commit; the `name` field appears to be empty, so I get an error when I try to 
apply the patch
  
  
  That's weird. It is the very same machine which I previously used to submit 
all of my revisions, and actual commits look fine, too 
.
 I'll look into it tomorrow when I get to that PC.
  
  In D13921#288014 , @ngraham wrote:
  
  > Are you planning to update `konqueror/settings/konq/behaviour.cpp` as the 
comment asked? ;)
  
  
  As @dfaure said, these things are no longer there, that's why I had changed 
the comment to point to the new location.
  
  In D13921#288178 , @ngraham wrote:
  
  > Do you have commit access yet?
  
  
  I do, thanks! Will land tomorrow.

REPOSITORY
  R241 KIO

BRANCH
  dont_confirm_trash

REVISION DETAIL
  https://phabricator.kde.org/D13921

To: aleksejshilin, dfaure, #frameworks, #dolphin, ngraham
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D13921: Don't show confirmation dialog for Trash action by default

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.


  Perfect!
  
  Do you have commit access yet?

REPOSITORY
  R241 KIO

BRANCH
  dont_confirm_trash

REVISION DETAIL
  https://phabricator.kde.org/D13921

To: aleksejshilin, dfaure, #frameworks, #dolphin, ngraham
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D13921: Don't show confirmation dialog for Trash action by default

[David Faure]

dfaure accepted this revision.
dfaure added a comment.
This revision is now accepted and ready to land.


  In D13921#288014 , @ngraham wrote:
  
  > Are you planning to update `konqueror/settings/konq/behaviour.cpp` as the 
comment asked? ;)
  
  
  AFAICS that file doesn't have anything about confirmation-for-deletions 
anymore. Probably ever since konqueror embeds dolphinpart.

REPOSITORY
  R241 KIO

BRANCH
  dont_confirm_trash

REVISION DETAIL
  https://phabricator.kde.org/D13921

To: aleksejshilin, dfaure, #frameworks, #dolphin
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D13921: Don't show confirmation dialog for Trash action by default

[Nathaniel Graham]

ngraham added reviewers: Frameworks, Dolphin.
ngraham added a comment.


  The actual code change looks sane and fixes the bug.
  
  Are you planning to update `konqueror/settings/konq/behaviour.cpp` as the 
comment asked? ;)

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D13921

To: aleksejshilin, dfaure, #frameworks, #dolphin
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D13921: Don't show confirmation dialog for Trash action by default

[Nathaniel Graham]

ngraham added a comment.


  There's a problem with the git setup on the computer you used to make this 
commit; the `name` field appears to be empty, so I get an error when I try to 
apply the patch:
  
Created and checked out branch arcpatch-D13921.
Checking patch src/widgets/jobuidelegate.cpp...
Applied patch src/widgets/jobuidelegate.cpp cleanly.
Exception
Command failed with error #128!
COMMAND
git commit -a --author='  ' -F - --no-verify

STDOUT
(empty)

STDERR
fatal: empty ident name (for ) not allowed

(Run with `--trace` for a full exception trace.)

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D13921

To: aleksejshilin, dfaure
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D13921: Don't show confirmation dialog for Trash action by default

[Алексей Шилин]

aleksejshilin created this revision.
aleksejshilin added a reviewer: dfaure.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: kde-frameworks-devel.
aleksejshilin requested review of this revision.

REVISION SUMMARY
  Dolphin and KIO default confirmation settings were not in sync: the former
  defaults to not showing the dialog while the latter used to default to the
  opposite.
  
  This change resolves the inconsistency by adjusting KIO defaults.
  
  BUG: 385492

TEST PLAN
  1. Create a new user account and log into it.
  2. Open Dolphin.
  3. Create a text file and hit Del. The confirmation dialog should *not* 
appear.
  4. Check that permanent deletion (Shift+Del) and emptying the Trash still 
show the confirmation dialog.

REPOSITORY
  R241 KIO

BRANCH
  dont_confirm_trash

REVISION DETAIL
  https://phabricator.kde.org/D13921

AFFECTED FILES
  src/widgets/jobuidelegate.cpp

To: aleksejshilin, dfaure
Cc: kde-frameworks-devel, michaelh, ngraham, bruns