D14095: Fix DownloadDialog window margins to meet general theme margins

2018-07-16 Thread Friedrich W. H. Kossebau 
This revision was automatically updated to reflect the committed changes.
Closed by commit R304:6c4fe2cf761d: Fix DownloadDialog window margins to meet 
general theme margins (authored by kossebau).

REPOSITORY
  R304 KNewStuff

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D14095?vs=37692=37853

REVISION DETAIL
  https://phabricator.kde.org/D14095

AFFECTED FILES
  src/downloaddialog.cpp

To: kossebau, leinir
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D14095: Fix DownloadDialog window margins to meet general theme margins

2018-07-16 Thread Dan Leinir Turthra Jensen 
leinir accepted this revision.
leinir added a comment.
This revision is now accepted and ready to land.


  In principle, this would really want to go via the designers, but at the same 
time it does seem that this was what was originally intended anyway. Shippit :)

REPOSITORY
  R304 KNewStuff

BRANCH
  fixdownloaddialogmarginstake2

REVISION DETAIL
  https://phabricator.kde.org/D14095

To: kossebau, leinir
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D14095: Fix DownloadDialog window margins to meet general theme margins

2018-07-13 Thread Friedrich W. H. Kossebau 
kossebau created this revision.
kossebau added a reviewer: leinir.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: kde-frameworks-devel.
kossebau requested review of this revision.

REVISION SUMMARY
  Old code prevented the widget theme to use windowborder-specific margins for 
the
  effective outer margins.

TEST PLAN
  Content of Download dialog now has same margins to window border like other 
dialogs.

REPOSITORY
  R304 KNewStuff

BRANCH
  fixdownloaddialogmarginstake2

REVISION DETAIL
  https://phabricator.kde.org/D14095

AFFECTED FILES
  src/downloaddialog.cpp

To: kossebau, leinir
Cc: kde-frameworks-devel, michaelh, ngraham, bruns