D14097: Change default sort order in the download dialog to Rating

2018-07-16 Thread Nathaniel Graham
ngraham closed this revision.

REPOSITORY
  R304 KNewStuff

REVISION DETAIL
  https://phabricator.kde.org/D14097

To: ngraham, apol, leinir, #knewstuff
Cc: kde-frameworks-devel, michaelh, ngraham, bruns


D14097: Change default sort order in the download dialog to Rating

2018-07-16 Thread Dan Leinir Turthra Jensen
leinir accepted this revision.
leinir added a comment.
This revision is now accepted and ready to land.


  As an aside, I'd probably like this to end up being remembered between 
sessions, but this no different to the current state, and so outside the scope 
of this patch. As a default setting, yup, sorting by Rating definitely makes 
better sense than Newest :) (Newest would make better sense for people who look 
regularly, but Rating is definitely the best first-run thing, and that's the 
experience we're trying to improve - we can get to remembering the state later 
on, if everybody else agrees that that's something we want to do)

REPOSITORY
  R304 KNewStuff

BRANCH
  sort-by-rating-by-default (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D14097

To: ngraham, apol, leinir, #knewstuff
Cc: kde-frameworks-devel, michaelh, ngraham, bruns


D14097: Change default sort order in the download dialog to Rating

2018-07-13 Thread Aleix Pol Gonzalez
apol added a comment.


  +1 this makes most sense to me.

REPOSITORY
  R304 KNewStuff

REVISION DETAIL
  https://phabricator.kde.org/D14097

To: ngraham, apol, leinir, #knewstuff
Cc: kde-frameworks-devel, michaelh, ngraham, bruns


D14097: Change default sort order in the download dialog to Rating

2018-07-13 Thread Nathaniel Graham
ngraham edited the test plan for this revision.

REPOSITORY
  R304 KNewStuff

REVISION DETAIL
  https://phabricator.kde.org/D14097

To: ngraham, apol, leinir, #knewstuff
Cc: kde-frameworks-devel, michaelh, ngraham, bruns


D14097: Change default sort order in the download dialog to Rating

2018-07-13 Thread Nathaniel Graham
ngraham created this revision.
ngraham added reviewers: apol, leinir, KNewStuff.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: kde-frameworks-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  This changed the default sort ordering of the download dialog to Rating, for 
the following reasons:
  
  - It's more relevant and useful to users to see content that the community 
thinks is best by default instead of simply what's been uploaded most recently
  - Match Discover's default sort ordering for KNS content

TEST PLAN
  Open a GHNS dialog and see that the default sort ordering of the content is 
by Rating, and that the Rating radio button is checked:

REPOSITORY
  R304 KNewStuff

BRANCH
  sort-by-rating-by-default (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D14097

AFFECTED FILES
  src/downloadwidget.cpp
  src/downloadwidget.ui

To: ngraham, apol, leinir, #knewstuff
Cc: kde-frameworks-devel, michaelh, ngraham, bruns