D14107: [Telegram] Don't wait for Telegram to be closed

2018-07-16 Thread Nicolas Fella
This revision was automatically updated to reflect the committed changes.
Closed by commit R495:6803b1203e46: [Telegram] Dont wait for Telegram to 
be closed (authored by nicolasfella).

REPOSITORY
  R495 Purpose Library

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D14107?vs=37723=37875

REVISION DETAIL
  https://phabricator.kde.org/D14107

AFFECTED FILES
  src/plugins/telegram/telegramplugin.cpp

To: nicolasfella, apol
Cc: kde-frameworks-devel, michaelh, ngraham, bruns


D14107: [Telegram] Don't wait for Telegram to be closed

2018-07-16 Thread Aleix Pol Gonzalez
apol accepted this revision.
apol added a comment.
This revision is now accepted and ready to land.


  I guess this only happens if Telegram wasn't running already.

REPOSITORY
  R495 Purpose Library

BRANCH
  finishtelegramjob

REVISION DETAIL
  https://phabricator.kde.org/D14107

To: nicolasfella, apol
Cc: kde-frameworks-devel, michaelh, ngraham, bruns


D14107: [Telegram] Don't wait for Telegram to be closed

2018-07-13 Thread Nicolas Fella
nicolasfella created this revision.
nicolasfella added a reviewer: apol.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: kde-frameworks-devel.
nicolasfella requested review of this revision.

REVISION SUMMARY
  Unlike e.g. kdeconnect-cli telegram stays open after sharing. The Job lives 
as long as telegram is running, 
  although the exit code is not interesting. Another window with a useless 
progress bar is open all the time, 
  which is especially annoying when using a tiling window manager. This patch 
waits shortly and stops the job 
  while keeping telegram open. Directly stopping the job would cause telegram 
not to open at all. The waiting 
  time is somewhat ad-hoc, but works well in my case.

TEST PLAN
  Share something via Telegram. See progress window open shortly and close 
again. Telegram stays
  open, ready to share

REPOSITORY
  R495 Purpose Library

BRANCH
  finishtelegramjob

REVISION DETAIL
  https://phabricator.kde.org/D14107

AFFECTED FILES
  src/plugins/telegram/telegramplugin.cpp

To: nicolasfella, apol
Cc: kde-frameworks-devel, michaelh, ngraham, bruns