D14161: [KStyle] Use dialog-question for question icon

[Nathaniel Graham]

ngraham added a comment.


  In D14161#294031 , @rkflx wrote:
  
  > Thanks for noticing, LGTM and restores the proper icon indeed.
  >
  > > This was changed in `KMessageBox` in 
9b05a12a43dbe2b31a4655052f20de0832ac7a61 
 but 
never "upstreamed" to `KStyle`
  >
  > Sorry, did not know about this, and neither did the reviewer notice.
  >
  > Should I submit Diffs (or commit directly?) where the wrong icon is still 
in use, e.g. here 
, 
here 
, 
here 

 and/or here 
?
  
  
  Yes please. Committing directly should be fine.

REPOSITORY
  R252 Framework Integration

REVISION DETAIL
  https://phabricator.kde.org/D14161

To: broulik, dfaure, ngraham, rkflx
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D14161: [KStyle] Use dialog-question for question icon

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R252:baf011a72ffc: [KStyle] Use dialog-question for question 
icon (authored by broulik).

REPOSITORY
  R252 Framework Integration

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D14161?vs=37885=39287

REVISION DETAIL
  https://phabricator.kde.org/D14161

AFFECTED FILES
  src/kstyle/kstyle.cpp

To: broulik, dfaure, ngraham, rkflx
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D14161: [KStyle] Use dialog-question for question icon

[Henrik Fehlauer]

rkflx accepted this revision.
rkflx added a comment.
This revision is now accepted and ready to land.


  Thanks for noticing, LGTM and restores the proper icon indeed.
  
  > This was changed in `KMessageBox` in 
9b05a12a43dbe2b31a4655052f20de0832ac7a61 
 but 
never "upstreamed" to `KStyle`
  
  Sorry, did not know about this, and neither did the reviewer notice.
  
  Should I submit Diffs (or commit directly?) where the wrong icon is still in 
use, e.g. here 
, 
here 
, 
here 

 and/or here 
?

REPOSITORY
  R252 Framework Integration

REVISION DETAIL
  https://phabricator.kde.org/D14161

To: broulik, dfaure, ngraham, rkflx
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D14161: [KStyle] Use dialog-question for question icon

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: dfaure, ngraham, rkflx.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: kde-frameworks-devel.
broulik requested review of this revision.

REVISION SUMMARY
  This was changed in `KMessageBox` in 9b05a12a43dbe2b31a4655052f20de0832ac7a61 
 but 
never "upstreamed" to `KStyle` which wasn't an issue until D14160 

  
  `dialog-information` is kept as a fallback since e.g. Oxygen doesn't have 
`dialog-question` since using that icon is a pretty new addition

TEST PLAN
  `kdialog --yesno "test"` shows question mark icon again in Breeze. shows 
information icon still with Oxygen.

REPOSITORY
  R252 Framework Integration

REVISION DETAIL
  https://phabricator.kde.org/D14161

AFFECTED FILES
  src/kstyle/kstyle.cpp

To: broulik, dfaure, ngraham, rkflx
Cc: kde-frameworks-devel, michaelh, ngraham, bruns