D14531: [Icon Item] Use ItemEnabledHasChanged

2018-08-17 Thread Kai Uwe Broulik 
This revision was automatically updated to reflect the committed changes.
Closed by commit R242:e143f7d457f6: [Icon Item] Use ItemEnabledHasChanged 
(authored by broulik).

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D14531?vs=38891=39923

REVISION DETAIL
  https://phabricator.kde.org/D14531

AFFECTED FILES
  src/declarativeimports/core/iconitem.cpp

To: broulik, #plasma, davidedmundson
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D14531: [Icon Item] Use ItemEnabledHasChanged

2018-08-17 Thread David Edmundson 
davidedmundson accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D14531

To: broulik, #plasma, davidedmundson
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D14531: [Icon Item] Use ItemEnabledHasChanged

2018-08-01 Thread Kai Uwe Broulik 
broulik created this revision.
broulik added reviewers: Plasma, davidedmundson.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: kde-frameworks-devel.
broulik requested review of this revision.

REVISION SUMMARY
  Preferred over having a connect and it go through meta signal invocation when 
it's emitted

TEST PLAN
  New in Qt 5.10, same was done with `visible` a while ago
  Icon enabled state in e.g. fullscreen dashboard working fine
  Iconitem test still passes

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D14531

AFFECTED FILES
  src/declarativeimports/core/iconitem.cpp

To: broulik, #plasma, davidedmundson
Cc: kde-frameworks-devel, michaelh, ngraham, bruns