D14580: support for multi pages kcms

2018-10-10 Thread Marco Martin 
This revision was automatically updated to reflect the committed changes.
Closed by commit R295:58e3b29efb99: support for multi pages kcms (authored by 
mart).

REPOSITORY
  R295 KCMUtils

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D14580?vs=43279=43280

REVISION DETAIL
  https://phabricator.kde.org/D14580

AFFECTED FILES
  src/CMakeLists.txt
  src/kcmoduleqml.cpp
  src/kcmultidialog.cpp

To: mart, #plasma, #frameworks, davidedmundson
Cc: abetts, kde-frameworks-devel, michaelh, ngraham, bruns

D14580: support for multi pages kcms

2018-10-10 Thread Marco Martin 
mart updated this revision to Diff 43279.
mart added a comment.


  - Merge branch 'master' into arcpatch-D14580

REPOSITORY
  R295 KCMUtils

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D14580?vs=40629=43279

BRANCH
  arcpatch-D14580

REVISION DETAIL
  https://phabricator.kde.org/D14580

AFFECTED FILES
  src/CMakeLists.txt
  src/kcmoduleqml.cpp
  src/kcmultidialog.cpp

To: mart, #plasma, #frameworks, davidedmundson
Cc: abetts, kde-frameworks-devel, michaelh, ngraham, bruns

D14580: support for multi pages kcms

2018-10-08 Thread David Edmundson 
davidedmundson accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R295 KCMUtils

BRANCH
  mart/multipageKCM

REVISION DETAIL
  https://phabricator.kde.org/D14580

To: mart, #plasma, #frameworks, davidedmundson
Cc: abetts, kde-frameworks-devel, michaelh, ngraham, bruns

D14580: support for multi pages kcms

2018-08-29 Thread Andres Betts 
abetts added a comment.


  In D14580#317289 , @mart wrote:
  
  > F6223394: Spectacle.k3.png 
  >
  > in case the kcm wants to go multi columns (default off):
  >  F6223399: Spectacle.l3.png 
  >  that secon page with the giant pop button is just a placeholder for testing
  
  
  Very cool! Thanks for the pics Marco!

REPOSITORY
  R295 KCMUtils

REVISION DETAIL
  https://phabricator.kde.org/D14580

To: mart, #plasma, #frameworks
Cc: abetts, kde-frameworks-devel, michaelh, ngraham, bruns

D14580: support for multi pages kcms

2018-08-29 Thread Marco Martin 
mart added a comment.


  F6223394: Spectacle.k3.png 
  
  in case the kcm wants to go multi columns (default off):
  F6223399: Spectacle.l3.png 

REPOSITORY
  R295 KCMUtils

REVISION DETAIL
  https://phabricator.kde.org/D14580

To: mart, #plasma, #frameworks
Cc: abetts, kde-frameworks-devel, michaelh, ngraham, bruns

D14580: support for multi pages kcms

2018-08-29 Thread Andres Betts 
abetts added a comment.


  What does this look like now Marco?

REPOSITORY
  R295 KCMUtils

REVISION DETAIL
  https://phabricator.kde.org/D14580

To: mart, #plasma, #frameworks
Cc: abetts, kde-frameworks-devel, michaelh, ngraham, bruns

D14580: support for multi pages kcms

2018-08-29 Thread Marco Martin 
mart updated this revision to Diff 40629.
mart added a comment.


  - cosmetic spacing

REPOSITORY
  R295 KCMUtils

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D14580?vs=40625=40629

BRANCH
  mart/multipageKCM

REVISION DETAIL
  https://phabricator.kde.org/D14580

AFFECTED FILES
  src/CMakeLists.txt
  src/kcmoduleqml.cpp
  src/kcmoduleqml_p.h
  src/kcmultidialog.cpp

To: mart, #plasma, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D14580: support for multi pages kcms

2018-08-29 Thread Marco Martin 
mart updated this revision to Diff 40625.
mart added a comment.


  hide title of qml modules from KCMultidialog

REPOSITORY
  R295 KCMUtils

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D14580?vs=40500=40625

BRANCH
  mart/multipageKCM

REVISION DETAIL
  https://phabricator.kde.org/D14580

AFFECTED FILES
  src/CMakeLists.txt
  src/kcmoduleqml.cpp
  src/kcmoduleqml_p.h
  src/kcmultidialog.cpp

To: mart, #plasma, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D14580: support for multi pages kcms

2018-08-27 Thread Marco Martin 
mart updated this revision to Diff 40500.
mart added a comment.


  - use the new ConfigMoule push/pop api

REPOSITORY
  R295 KCMUtils

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D14580?vs=40370=40500

BRANCH
  mart/multipageKCM

REVISION DETAIL
  https://phabricator.kde.org/D14580

AFFECTED FILES
  src/CMakeLists.txt
  src/kcmoduleqml.cpp
  src/kcmoduleqml_p.h

To: mart, #plasma, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D14580: support for multi pages kcms

2018-08-24 Thread Marco Martin 
mart updated this revision to Diff 40370.
mart added a comment.


  - retrocompatibility hack with systemsettings

REPOSITORY
  R295 KCMUtils

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D14580?vs=39310=40370

BRANCH
  mart/multipageKCM

REVISION DETAIL
  https://phabricator.kde.org/D14580

AFFECTED FILES
  src/CMakeLists.txt
  src/kcmoduleqml.cpp
  src/kcmoduleqml_p.h

To: mart, #plasma, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D14580: support for multi pages kcms

2018-08-08 Thread Marco Martin 
mart updated this revision to Diff 39310.
mart added a comment.


  - paint internally the title and breadcrumb

REPOSITORY
  R295 KCMUtils

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D14580?vs=39018=39310

BRANCH
  mart/multipageKCM

REVISION DETAIL
  https://phabricator.kde.org/D14580

AFFECTED FILES
  src/CMakeLists.txt
  src/kcmoduleqml.cpp
  src/kcmoduleqml_p.h

To: mart, #plasma, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D14580: support for multi pages kcms

2018-08-03 Thread Marco Martin 
mart added a reviewer: Frameworks.

REPOSITORY
  R295 KCMUtils

REVISION DETAIL
  https://phabricator.kde.org/D14580

To: mart, #plasma, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D14580: support for multi pages kcms

2018-08-03 Thread Marco Martin 
mart created this revision.
mart added a reviewer: Plasma.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: kde-frameworks-devel.
mart requested review of this revision.

REVISION SUMMARY
  support multiple levels for QML kcms.
  use a Kirigami.ApplicationItem, so qml kcms can now use the full Kirigami api
  and use the application's pagerow for their levels.
  The breadcrumb of levels is supposed to be shown by the systemsettings shell.
  Depends on D14579 

TEST PLAN
  Old kcms still work as they did
  a mqml kcm can push multiple pages

REPOSITORY
  R295 KCMUtils

BRANCH
  mart/multipageKCM

REVISION DETAIL
  https://phabricator.kde.org/D14580

AFFECTED FILES
  src/CMakeLists.txt
  src/kcmoduleqml.cpp
  src/kcmoduleqml_p.h

To: mart, #plasma
Cc: kde-frameworks-devel, michaelh, ngraham, bruns