D14593: Update Logtalk language syntax support
dhaumann added a comment. Thanks goes to do - and sorry for the delay on our side. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D14593 To: pmoura, dhaumann, cullmann, vkrause, #framework_syntax_highlighting, #kate Cc: kwrite-devel, kde-frameworks-devel, pmoura, michaelh, genethomas, kevinapavew, ngraham, bruns, demsking, cullmann, vkrause, sars, dhaumann
D14593: Update Logtalk language syntax support
This revision was automatically updated to reflect the committed changes. Closed by commit R216:2ce2523452eb: Update Logtalk language syntax support (authored by dhaumann). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D14593?vs=39566&id=39568#toc REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14593?vs=39566&id=39568 REVISION DETAIL https://phabricator.kde.org/D14593 AFFECTED FILES autotests/folding/highlight.lgt.fold autotests/html/highlight.lgt.html autotests/input/highlight.lgt autotests/reference/highlight.lgt.ref data/syntax/logtalk.xml To: pmoura, dhaumann, cullmann, vkrause, #framework_syntax_highlighting, #kate Cc: kwrite-devel, kde-frameworks-devel, pmoura, michaelh, genethomas, kevinapavew, ngraham, bruns, demsking, cullmann, vkrause, sars, dhaumann
D14593: Update Logtalk language syntax support
pmoura added a comment. Thanks for your help! REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D14593 To: pmoura, dhaumann, cullmann, vkrause, #framework_syntax_highlighting, #kate Cc: kwrite-devel, kde-frameworks-devel, pmoura, michaelh, genethomas, kevinapavew, ngraham, bruns, demsking, cullmann, vkrause, sars, dhaumann
D14593: Update Logtalk language syntax support
cullmann accepted this revision. This revision is now accepted and ready to land. REVISION DETAIL https://phabricator.kde.org/D14593 To: pmoura, dhaumann, cullmann, vkrause, #framework_syntax_highlighting, #kate Cc: kwrite-devel, kde-frameworks-devel, pmoura, michaelh, genethomas, kevinapavew, ngraham, bruns, demsking, cullmann, vkrause, sars, dhaumann
D14593: Update Logtalk language syntax support
pmoura added a comment. I'm on macOS and I only forked from GitHub the `syntax-highlighting` repo. I don't have the necessary infra-structure to compile `KSyntaxHighlighting` and generate the reference files. I would very much appreciate if you can take it from here. I did test the updated syntax highlight support for Logtalk by replacing the `data/syntax/logtalk.xml` in a borrowed Ubuntu box, opening the test file, and checking that everything was highlight perfectly. REVISION DETAIL https://phabricator.kde.org/D14593 To: pmoura, dhaumann, cullmann, vkrause, #framework_syntax_highlighting, #kate Cc: kwrite-devel, kde-frameworks-devel, pmoura, michaelh, genethomas, kevinapavew, ngraham, bruns, demsking, cullmann, vkrause, sars, dhaumann
D14593: Update Logtalk language syntax support
dhaumann accepted this revision. dhaumann added a comment. Shall we integrate this, or can you commit yourself? REVISION DETAIL https://phabricator.kde.org/D14593 To: pmoura, dhaumann, cullmann, vkrause, #framework_syntax_highlighting, #kate Cc: kwrite-devel, kde-frameworks-devel, pmoura, michaelh, genethomas, kevinapavew, ngraham, bruns, demsking, cullmann, vkrause, sars, dhaumann
D14593: Update Logtalk language syntax support
pmoura updated this revision to Diff 39566. pmoura added a comment. Added license to Logtalk highlighting test file. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14593?vs=39558&id=39566 REVISION DETAIL https://phabricator.kde.org/D14593 AFFECTED FILES autotests/input/highlight.lgt data/syntax/logtalk.xml To: pmoura, dhaumann, cullmann, vkrause, #framework_syntax_highlighting, #kate Cc: kwrite-devel, kde-frameworks-devel, pmoura, michaelh, genethomas, kevinapavew, ngraham, bruns, demsking, cullmann, vkrause, sars, dhaumann
D14593: Update Logtalk language syntax support
dhaumann added a comment. Ok, perfect, thanks! I think "Apache License 2.0" is fine as well. It's just important that we do know the license, because otherwise it's a mess over time. How to create the reference. When compiling KSyntaxHighlighting, you then write: - make - make test make test will run all unit tests, and create new files in the build directory: - highlight.lgt.fold - highlight.lgt.html - highlight.lgt.ref These can be copied into the source folder by running in the build folder: ./autotests/update-reference-data.sh REVISION DETAIL https://phabricator.kde.org/D14593 To: pmoura, dhaumann, cullmann, vkrause, #framework_syntax_highlighting, #kate Cc: kwrite-devel, kde-frameworks-devel, pmoura, michaelh, genethomas, kevinapavew, ngraham, bruns, demsking, cullmann, vkrause, sars, dhaumann
D14593: Update Logtalk language syntax support
cullmann added a comment. If there is no redundancy, I am ok with that file. The license should be stated in it explicitly, will make it later easier to understand why we can use that. For the reference generation: after a run, you will get told that stuff diffs, e.g. you do make test and the tests will fail You then can look at the output in the autotests folder and copy the matching output files to the references folder in the framework. REVISION DETAIL https://phabricator.kde.org/D14593 To: pmoura, dhaumann, cullmann, vkrause, #framework_syntax_highlighting, #kate Cc: kwrite-devel, kde-frameworks-devel, pmoura, michaelh, genethomas, kevinapavew, ngraham, bruns, demsking, cullmann, vkrause, sars, dhaumann
D14593: Update Logtalk language syntax support
pmoura added a comment. The test file tests everything that should be highlighted properly. There is no redundancy in it. It is large due to testing all built-in language features, including all that would be called keywords in other languages. It is the same test file that is used to check Logtalk syntax highlighting for two dozens of text editors and syntax highlighters. The original file is part of the Logtalk distribution and thus uses the Apache License 2.0. This version, `highlight.lgt` can be re-licensed using the license preferred for your project. Note that the contents of the file are just for testing highlighting and make no sense as an actual compilable source code. REVISION DETAIL https://phabricator.kde.org/D14593 To: pmoura, dhaumann, cullmann, vkrause, #framework_syntax_highlighting, #kate Cc: kwrite-devel, kde-frameworks-devel, pmoura, michaelh, genethomas, kevinapavew, ngraham, bruns, demsking, cullmann, vkrause, sars, dhaumann
D14593: Update Logtalk language syntax support
dhaumann added a comment. Just curious: The test file looks good to me, but it looks to me that it also contains some redundancy: Think of it as follows: We use this for unit testing. As such, the best case is that a test file tests all the corner cases, but ideally only once. If a test fails, then we get a diff with the changed highlighting information. And if the file is 400 lines of code, checking for regressions is much more work compared to if the file only contains e.g. 50 lines. So: would it be possible to strip it down a bit? And also: Is this file freely usable, e.g. licensed under MIT? Would be nice to add a license comment in the first line. REVISION DETAIL https://phabricator.kde.org/D14593 To: pmoura, dhaumann, cullmann, vkrause, #framework_syntax_highlighting, #kate Cc: kwrite-devel, kde-frameworks-devel, pmoura, michaelh, genethomas, kevinapavew, ngraham, bruns, demsking, cullmann, vkrause, sars, dhaumann
D14593: Update Logtalk language syntax support
pmoura added a comment. How do generate the reference files? No idea of what you mean by " let it run". REVISION DETAIL https://phabricator.kde.org/D14593 To: pmoura, dhaumann, cullmann, vkrause, #framework_syntax_highlighting, #kate Cc: kwrite-devel, kde-frameworks-devel, pmoura, michaelh, genethomas, kevinapavew, ngraham, bruns, demsking, cullmann, vkrause, sars, dhaumann
D14593: Update Logtalk language syntax support
pmoura updated this revision to Diff 39558. pmoura added a comment. Added `autotests/input/highlight.lgt` file. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14593?vs=39556&id=39558 REVISION DETAIL https://phabricator.kde.org/D14593 AFFECTED FILES autotests/input/highlight.lgt data/syntax/logtalk.xml To: pmoura, dhaumann, cullmann, vkrause, #framework_syntax_highlighting, #kate Cc: kwrite-devel, kde-frameworks-devel, pmoura, michaelh, genethomas, kevinapavew, ngraham, bruns, demsking, cullmann, vkrause, sars, dhaumann
D14593: Update Logtalk language syntax support
cullmann added a comment. Yes, and then let it run and review the results + add the reference files. That would be more than enough and we ensure with that it doesn't regress on later refactoring/bugfixes. Thanks! REPOSITORY R40 Kate REVISION DETAIL https://phabricator.kde.org/D14593 To: pmoura, dhaumann, cullmann, vkrause, #framework_syntax_highlighting, #kate Cc: kwrite-devel, kde-frameworks-devel, pmoura, michaelh, genethomas, kevinapavew, ngraham, bruns, demsking, cullmann, vkrause, sars, dhaumann
D14593: Update Logtalk language syntax support
pmoura added a comment. Would adding the sample Logtalk source file I mentioned renamed to `highlight.lgt` to the `autotests/input` folder do? REPOSITORY R40 Kate REVISION DETAIL https://phabricator.kde.org/D14593 To: pmoura, dhaumann, cullmann, vkrause, #framework_syntax_highlighting, #kate Cc: kwrite-devel, kde-frameworks-devel, pmoura, michaelh, genethomas, kevinapavew, ngraham, bruns, demsking, cullmann, vkrause, sars, dhaumann
D14593: Update Logtalk language syntax support
cullmann added a comment. Could you provide a test file for the autotests unit tests? REPOSITORY R40 Kate REVISION DETAIL https://phabricator.kde.org/D14593 To: pmoura, dhaumann, cullmann, vkrause, #framework_syntax_highlighting, #kate Cc: kwrite-devel, kde-frameworks-devel, pmoura, michaelh, genethomas, kevinapavew, ngraham, bruns, demsking, cullmann, vkrause, sars, dhaumann
D14593: Update Logtalk language syntax support
pmoura updated this revision to Diff 39556. pmoura added a comment. Update Logtalk language syntax support per reviewer request. REPOSITORY R40 Kate CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14593?vs=39051&id=39556 REVISION DETAIL https://phabricator.kde.org/D14593 AFFECTED FILES data/syntax/logtalk.xml To: pmoura, dhaumann, cullmann, vkrause, #framework_syntax_highlighting, #kate Cc: kwrite-devel, kde-frameworks-devel, pmoura, michaelh, genethomas, kevinapavew, ngraham, bruns, demsking, cullmann, vkrause, sars, dhaumann
D14593: Update Logtalk language syntax support
cullmann requested changes to this revision. cullmann added a comment. This revision now requires changes to proceed. Thanks for the contribution. I think the version=... should just be an integer, just increment it by one. Beside that, it would be very nice to have some test file in the autotests folder like for other languages for this with the new features you cover (at least some parts would already be nice). REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D14593 To: pmoura, dhaumann, cullmann, vkrause, #framework_syntax_highlighting, #kate Cc: kwrite-devel, kde-frameworks-devel, pmoura, michaelh, genethomas, kevinapavew, ngraham, bruns, demsking, cullmann, vkrause, sars, dhaumann
D14593: Update Logtalk language syntax support
nibags added reviewers: dhaumann, cullmann, vkrause, Framework: Syntax Highlighting, Kate. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D14593 To: pmoura, dhaumann, cullmann, vkrause, #framework_syntax_highlighting, #kate Cc: kwrite-devel, kde-frameworks-devel, pmoura, michaelh, genethomas, kevinapavew, ngraham, bruns, demsking, cullmann, vkrause, sars, dhaumann
D14593: Update Logtalk language syntax support
pmoura created this revision. pmoura added a project: Framework: Syntax Highlighting. Restricted Application added projects: Kate, Frameworks. Restricted Application added subscribers: kde-frameworks-devel, kwrite-devel. pmoura requested review of this revision. REVISION SUMMARY Update Logtalk language syntax support for the latest language specification (3.19.0). TEST PLAN Tested using the sample Logtalk source file available at: https://github.com/LogtalkDotOrg/logtalk3/tree/master/coding/tests REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D14593 AFFECTED FILES data/syntax/logtalk.xml To: pmoura Cc: kwrite-devel, kde-frameworks-devel, pmoura, michaelh, genethomas, kevinapavew, ngraham, bruns, demsking, cullmann, vkrause, sars, dhaumann
