D14692: Use custom QScrollArea with size hint not limited by font size
valeriymalov created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. valeriymalov requested review of this revision. REVISION SUMMARY For some reason original QScrollArea has constraint on a size hint This causes large KCMShell pages open in relatively small windows, because QScrollArea inside reports small size hint BUG: 389585 TEST PLAN patched 5.48.0 with this, tested networkmanager and few other kcms, they now seem to open in full size (except for kscreen which has custom sizehint, it probably needs size hint for the QML area specifically, not the whole window; and except for opengl that has it's own scrollable area which needs a size hint too) REPOSITORY R295 KCMUtils BRANCH master REVISION DETAIL https://phabricator.kde.org/D14692 AFFECTED FILES src/kcmultidialog.cpp src/kcmultidialog.h To: valeriymalov Cc: kde-frameworks-devel, michaelh, ngraham, bruns
D14692: Use custom QScrollArea with size hint not limited by font size
valeriymalov added a reviewer: Frameworks. valeriymalov added a comment. Context for the size hint limitation this patch is supposed to circumvent: https://code.woboq.org/qt5/qtbase/src/widgets/widgets/qscrollarea.cpp.html#403 REPOSITORY R295 KCMUtils REVISION DETAIL https://phabricator.kde.org/D14692 To: valeriymalov, #frameworks Cc: kde-frameworks-devel, michaelh, ngraham, bruns
D14692: Use custom QScrollArea with size hint not limited by font size
ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Wow, this works perfectly for me. I banged my head against this by trying to pass the sizeHint to the existing scrollview, so it makes sense to me know to know that a regular scrollView doesn't respect it. Do you know if there's a Qt bug tracking this? Since we're working around a Qt issue, I'd like a comment in the code with the Qt bug. Could it be https://bugreports.qt.io/browse/QTBUG-9591 or https://bugreports.qt.io/browse/QTBUG-10545? Both are closed, but if one is relevant, we should get a new bug filed for Qt 5. REPOSITORY R295 KCMUtils BRANCH master REVISION DETAIL https://phabricator.kde.org/D14692 To: valeriymalov, #frameworks, ngraham Cc: ngraham, kde-frameworks-devel, michaelh, bruns
D14692: Use custom QScrollArea with size hint not limited by font size
valeriymalov added a comment. I think it's this bug/suggestion: https://bugreports.qt.io/browse/QTBUG-10459 REPOSITORY R295 KCMUtils BRANCH master REVISION DETAIL https://phabricator.kde.org/D14692 To: valeriymalov, #frameworks, ngraham Cc: ngraham, kde-frameworks-devel, michaelh, bruns
D14692: Use custom QScrollArea with size hint not limited by font size
ngraham added a comment. OK, great! Could you add a comment in the code indicating that the custom scrollview is a workaround for that bug? REPOSITORY R295 KCMUtils BRANCH master REVISION DETAIL https://phabricator.kde.org/D14692 To: valeriymalov, #frameworks, ngraham Cc: ngraham, kde-frameworks-devel, michaelh, bruns
D14692: Use custom QScrollArea with size hint not limited by font size
valeriymalov updated this revision to Diff 39313. valeriymalov added a comment. - add link to qt bug REPOSITORY R295 KCMUtils CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14692?vs=39308&id=39313 BRANCH master REVISION DETAIL https://phabricator.kde.org/D14692 AFFECTED FILES src/kcmultidialog.cpp src/kcmultidialog.h To: valeriymalov, #frameworks, ngraham Cc: ngraham, kde-frameworks-devel, michaelh, bruns
D14692: Use custom QScrollArea with size hint not limited by font size
ngraham accepted this revision. ngraham added a comment. Thanks! REPOSITORY R295 KCMUtils BRANCH master REVISION DETAIL https://phabricator.kde.org/D14692 To: valeriymalov, #frameworks, ngraham Cc: ngraham, kde-frameworks-devel, michaelh, bruns
D14692: Use custom QScrollArea with size hint not limited by font size
ngraham added a comment. Are you waiting for another review before landing this? REPOSITORY R295 KCMUtils BRANCH master REVISION DETAIL https://phabricator.kde.org/D14692 To: valeriymalov, #frameworks, ngraham Cc: ngraham, kde-frameworks-devel, michaelh, bruns
D14692: Use custom QScrollArea with size hint not limited by font size
valeriymalov added a comment. I don't know, it's frameworks after all but I guess I can land it today since it's a popular bug. Should I just land it on master since there seem to be no other branches? REPOSITORY R295 KCMUtils BRANCH master REVISION DETAIL https://phabricator.kde.org/D14692 To: valeriymalov, #frameworks, ngraham Cc: ngraham, kde-frameworks-devel, michaelh, bruns
D14692: Use custom QScrollArea with size hint not limited by font size
ngraham added a comment. Yes please. REPOSITORY R295 KCMUtils BRANCH master REVISION DETAIL https://phabricator.kde.org/D14692 To: valeriymalov, #frameworks, ngraham Cc: ngraham, kde-frameworks-devel, michaelh, bruns
D14692: Use custom QScrollArea with size hint not limited by font size
This revision was automatically updated to reflect the committed changes. Closed by commit R295:23ba2b37ef82: Use custom QScrollArea with size hint not limited by font size (authored by valeriymalov). REPOSITORY R295 KCMUtils CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14692?vs=39313&id=39564 REVISION DETAIL https://phabricator.kde.org/D14692 AFFECTED FILES src/kcmultidialog.cpp src/kcmultidialog.h To: valeriymalov, #frameworks, ngraham Cc: ngraham, kde-frameworks-devel, michaelh, bruns
D14692: Use custom QScrollArea with size hint not limited by font size
ngraham added a comment. Thanks so much! REPOSITORY R295 KCMUtils REVISION DETAIL https://phabricator.kde.org/D14692 To: valeriymalov, #frameworks, ngraham Cc: ngraham, kde-frameworks-devel, michaelh, bruns
