D14910: Pass a dedicated fd to each keyboard for the xkb keymap

[Vlad Zahorodnii]

zzag added a comment.


  Urgh, the authorship information is screwed up. :/

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D14910

To: graesslin, #kwin, #frameworks, davidedmundson, zzag
Cc: plasma-devel, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns

D14910: Pass a dedicated fd to each keyboard for the xkb keymap

[Vlad Zahorodnii]

This revision was automatically updated to reflect the committed changes.
Closed by commit R127:6bfa71d89aee: Pass a dedicated fd to each keyboard for 
the xkb  keymap (authored by zzag).

REPOSITORY
  R127 KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D14910?vs=77916=78000

REVISION DETAIL
  https://phabricator.kde.org/D14910

AFFECTED FILES
  autotests/client/test_wayland_seat.cpp
  src/server/CMakeLists.txt
  src/server/keyboard_interface.cpp
  src/server/keyboard_interface.h
  src/server/keyboard_interface_p.h
  src/server/seat_interface.cpp
  src/server/seat_interface.h
  src/server/seat_interface_p.h

To: graesslin, #kwin, #frameworks, davidedmundson, zzag
Cc: plasma-devel, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns

D14910: Pass a dedicated fd to each keyboard for the xkb keymap

[Vlad Zahorodnii]

zzag updated this revision to Diff 77916.
zzag added a comment.


  Rebase on master

REPOSITORY
  R127 KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D14910?vs=39945=77916

BRANCH
  arcpatch-D14910

REVISION DETAIL
  https://phabricator.kde.org/D14910

AFFECTED FILES
  autotests/client/test_wayland_seat.cpp
  src/server/CMakeLists.txt
  src/server/keyboard_interface.cpp
  src/server/keyboard_interface.h
  src/server/keyboard_interface_p.h
  src/server/seat_interface.cpp
  src/server/seat_interface.h
  src/server/seat_interface_p.h

To: graesslin, #kwin, #frameworks, davidedmundson, zzag
Cc: plasma-devel, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns

D14910: Pass a dedicated fd to each keyboard for the xkb keymap

[Vlad Zagorodniy]

zzag accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D14910

To: graesslin, #kwin, #frameworks, davidedmundson, zzag
Cc: plasma-devel, kde-frameworks-devel, michaelh, ngraham, bruns

D14910: Pass a dedicated fd to each keyboard for the xkb keymap

[Martin Flöser]

graesslin added a subscriber: plasma-devel.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D14910

To: graesslin, #kwin, #frameworks, davidedmundson
Cc: plasma-devel, kde-frameworks-devel, michaelh, ngraham, bruns

D14910: Pass a dedicated fd to each keyboard for the xkb keymap

[Martin Flöser]

graesslin added a comment.


  Sorry for strange upload, arc decided to no longer like me.
  
  I created the patch on Jun 30, 2017. Unfortunately the issue was embargo on 
freedesktop.org with the idea of a coordinated release. Today the patch for 
weston landed so I consider the embargo as lifted. I had send the patch already 
to secur...@kde.org last year. Relevant freedesktop org bug is: 
https://bugs.freedesktop.org/show_bug.cgi?id=101595 - it might be that it's 
still private, if that's the case, please leave a note and I'll try to add to 
cc.
  
  Personal note: we are expecting our child any day now. So I cannot guarantee 
that I will have time to follow up or to push it. If you see inactivity: feel 
free to take over the patch and push it.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D14910

To: graesslin, #kwin, #frameworks, davidedmundson
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D14910: Pass a dedicated fd to each keyboard for the xkb keymap

[Martin Flöser]

graesslin created this revision.
graesslin added reviewers: KWin, Frameworks, davidedmundson.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
graesslin requested review of this revision.

REVISION SUMMARY
  To better isolate the clients from each other eachh KeyboardInterface
  creates it's own dedicated temporary file and sends the fd for this
  temporary file to the client. This means the memory for the keymap is no
  longer shared between all clients, every client has an own copy.
  
  To support this the existing API to set the keymap is deprecated and
  replaced by a new method setKeymapData which takes the content of the
  keymap as a byte array. The now deprecated method which takes a file
  descriptor is changed to use the new setKeymapData method. For that it
  reads the content of the file.
  
  The implementation in KeyboardInterface to create the file descriptor is
  based on the implementation of KWin. As I implemented the change in KWin
  (see 3b4c508ee36ac74c37e77fcaa14d106397ad2994 
) it 
is not a problem from
  GPL vs LGPL perspective.
  
  The change includes test cases to verify that the content of the keymap
  is properly passed to the client and that the memory is no longer shared.
  
  BUG: 381674

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D14910

AFFECTED FILES
  autotests/client/test_wayland_seat.cpp
  src/server/keyboard_interface.cpp
  src/server/keyboard_interface.h
  src/server/keyboard_interface_p.h
  src/server/seat_interface.cpp
  src/server/seat_interface.h
  src/server/seat_interface_p.h

To: graesslin, #kwin, #frameworks, davidedmundson
Cc: kde-frameworks-devel, michaelh, ngraham, bruns