D14938: Force ki18n to build with the libintl.so path

[Hannah von Reth]

This revision was automatically updated to reflect the committed changes.
Closed by commit R877:ccfb970b3206: Force ki18n to build with the libintl.so 
path (authored by sdepiets, committed by vonreth).

REPOSITORY
  R877 Craft Blueprints for KDE

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D14938?vs=40023&id=43947

REVISION DETAIL
  https://phabricator.kde.org/D14938

AFFECTED FILES
  kde/frameworks/tier1/ki18n/0002-Keep-LibIntl-libraries-path.patch
  kde/frameworks/tier1/ki18n/ki18n.py

To: sdepiets, #craft, vonreth, #frameworks, bcooksley, arichardson
Cc: sars, vonreth

D14938: Force ki18n to build with the libintl.so path

[Hannah von Reth]

vonreth accepted this revision.
vonreth added a comment.
This revision is now accepted and ready to land.


  its not optimal to patch this on our side but lets do it for now

REPOSITORY
  R877 Craft Blueprints for KDE

BRANCH
  ki18n_libintl_lib (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D14938

To: sdepiets, #craft, vonreth, #frameworks, bcooksley, arichardson
Cc: sars, vonreth

D14938: Force ki18n to build with the libintl.so path

[Simon Depiets]

sdepiets added a comment.


  In D14938#325850 , @sars wrote:
  
  > If I understand the comments correct it assumes that if we use a libc that 
already has what we need, we don't need to use a separate library for it.
  
  
  Correct me if I'm wrong, but I don't think "if(LibIntl_SYMBOL_FOUND)" 
discriminates between whether that symbol came from libc or not.

REPOSITORY
  R877 Craft Blueprints for KDE

REVISION DETAIL
  https://phabricator.kde.org/D14938

To: sdepiets, #craft, vonreth, #frameworks, bcooksley, arichardson
Cc: sars, vonreth

D14938: Force ki18n to build with the libintl.so path

[Simon Depiets]

sdepiets added a comment.


  In D14938#325850 , @sars wrote:
  
  > If I understand the comments correct it assumes that if we use a libc that 
already has what we need, we don't need to use a separate library for it.
  
  
  Correct me if I'm wrong, but I don't think "if(LibIntl_SYMBOL_FOUND)" 
discriminates between whether that symbol came from libc or not.

REPOSITORY
  R877 Craft Blueprints for KDE

REVISION DETAIL
  https://phabricator.kde.org/D14938

To: sdepiets, #craft, vonreth, #frameworks, bcooksley, arichardson
Cc: sars, vonreth

D14938: Force ki18n to build with the libintl.so path

[Kåre Särs]

sars added a comment.


  If I understand the comments correct it assumes that if we use a libc that 
already has what we need, we don't need to use a separate library for it.

REPOSITORY
  R877 Craft Blueprints for KDE

REVISION DETAIL
  https://phabricator.kde.org/D14938

To: sdepiets, #craft, vonreth, #frameworks, bcooksley, arichardson
Cc: sars, vonreth

D14938: Force ki18n to build with the libintl.so path

[Hannah von Reth]

vonreth added reviewers: bcooksley, arichardson.

REPOSITORY
  R877 Craft Blueprints for KDE

REVISION DETAIL
  https://phabricator.kde.org/D14938

To: sdepiets, #craft, vonreth, #frameworks, bcooksley, arichardson
Cc: vonreth

D14938: Force ki18n to build with the libintl.so path

[Hannah von Reth]

vonreth added a comment.


  Does anyone know why it prevents the usage of libintl? 
  And if there is a specific reason for that behaviour should we stop providing 
gettext on mac?

REPOSITORY
  R877 Craft Blueprints for KDE

REVISION DETAIL
  https://phabricator.kde.org/D14938

To: sdepiets, #craft, vonreth, #frameworks
Cc: vonreth

D14938: Force ki18n to build with the libintl.so path

[Hannah von Reth]

vonreth added a reviewer: Frameworks.

REPOSITORY
  R877 Craft Blueprints for KDE

REVISION DETAIL
  https://phabricator.kde.org/D14938

To: sdepiets, #craft, vonreth, #frameworks
Cc: vonreth