D14957: Create a first example of the use of KMessageBox

2018-08-20 Thread Olivier Churlaud 
This revision was automatically updated to reflect the committed changes.
Closed by commit R236:6748d24d5fb2: Create a first example of the use of 
KMessageBox (authored by ochurlaud).

REPOSITORY
  R236 KWidgetsAddons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D14957?vs=40094&id=40095

REVISION DETAIL
  https://phabricator.kde.org/D14957

AFFECTED FILES
  CMakeLists.txt
  examples/CMakeLists.txt
  examples/kmessagebox/CMakeLists.txt
  examples/kmessagebox/main.cpp

To: ochurlaud, #frameworks, dfaure
Cc: dfaure, kde-frameworks-devel, michaelh, ngraham, bruns

D14957: Create a first example of the use of KMessageBox

2018-08-20 Thread Olivier Churlaud 
ochurlaud marked an inline comment as done.

REPOSITORY
  R236 KWidgetsAddons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D14957

To: ochurlaud, #frameworks, dfaure
Cc: dfaure, kde-frameworks-devel, michaelh, ngraham, bruns

D14957: Create a first example of the use of KMessageBox

2018-08-20 Thread Olivier Churlaud 
ochurlaud updated this revision to Diff 40094.
ochurlaud added a comment.


  Fix as dfaure said

REPOSITORY
  R236 KWidgetsAddons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D14957?vs=40092&id=40094

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D14957

AFFECTED FILES
  CMakeLists.txt
  examples/CMakeLists.txt
  examples/kmessagebox/CMakeLists.txt
  examples/kmessagebox/main.cpp

To: ochurlaud, #frameworks, dfaure
Cc: dfaure, kde-frameworks-devel, michaelh, ngraham, bruns

D14957: Create a first example of the use of KMessageBox

2018-08-20 Thread David Faure 
dfaure accepted this revision.
dfaure added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> main.cpp:33
> +// Define a button
> +KGuiItem yesButton( QStringLiteral("Hello"), // the button label
> +QStringLiteral("view-filter"), // iconName, can be 
> empty to fallback to default

remove space after '('

REPOSITORY
  R236 KWidgetsAddons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D14957

To: ochurlaud, #frameworks, dfaure
Cc: dfaure, kde-frameworks-devel, michaelh, ngraham, bruns

D14957: Create a first example of the use of KMessageBox

2018-08-20 Thread Olivier Churlaud 
ochurlaud updated this revision to Diff 40092.
ochurlaud added a comment.


  Added licences and add some changes to fit what was done on D14955 


REPOSITORY
  R236 KWidgetsAddons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D14957?vs=40082&id=40092

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D14957

AFFECTED FILES
  CMakeLists.txt
  examples/CMakeLists.txt
  examples/kmessagebox/CMakeLists.txt
  examples/kmessagebox/main.cpp

To: ochurlaud, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D14957: Create a first example of the use of KMessageBox

2018-08-20 Thread Olivier Churlaud 
ochurlaud added a reviewer: Frameworks.

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D14957

To: ochurlaud, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D14957: Create a first example of the use of KMessageBox

2018-08-20 Thread Olivier Churlaud 
ochurlaud created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
ochurlaud requested review of this revision.

REVISION SUMMARY
  Based on https://techbase.kde.org/Development/Tutorials/First_program

TEST PLAN
  It compiles

REPOSITORY
  R236 KWidgetsAddons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D14957

AFFECTED FILES
  examples/kmessagebox/CMakeLists.txt
  examples/kmessagebox/main.cpp

To: ochurlaud
Cc: kde-frameworks-devel, michaelh, ngraham, bruns