D15021: Workaround bug with native rendering and opacity in TextField text
This revision was automatically updated to reflect the committed changes. Closed by commit R242:2faa71a55a75: Workaround bug with native rendering and opacity in TextField text (authored by davidedmundson). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15021?vs=40297&id=40542 REVISION DETAIL https://phabricator.kde.org/D15021 AFFECTED FILES src/declarativeimports/plasmastyle/TextFieldStyle.qml To: davidedmundson, #plasma, broulik Cc: ngraham, kde-frameworks-devel, michaelh, bruns
D15021: Workaround bug with native rendering and opacity in TextField text
ngraham added a comment. Anyway, confirmed that this works around the problem for me. +1 REPOSITORY R242 Plasma Framework (Library) BRANCH origin-master (branched from master) REVISION DETAIL https://phabricator.kde.org/D15021 To: davidedmundson, #plasma, broulik Cc: ngraham, kde-frameworks-devel, michaelh, bruns
D15021: Workaround bug with native rendering and opacity in TextField text
broulik added a comment. And potentially `QtQuickControlsPrivate` import but I recall it had some sideeffects that we needed, despite not using anything from it(?) REPOSITORY R242 Plasma Framework (Library) BRANCH origin-master (branched from master) REVISION DETAIL https://phabricator.kde.org/D15021 To: davidedmundson, #plasma, broulik Cc: ngraham, kde-frameworks-devel, michaelh, bruns
D15021: Workaround bug with native rendering and opacity in TextField text
ngraham added a comment. We could also get rid of the `import QtQuick.Window 2.2` line since it only existed to get `Screen.devicePixelRatio`, which this patch removes. REPOSITORY R242 Plasma Framework (Library) BRANCH origin-master (branched from master) REVISION DETAIL https://phabricator.kde.org/D15021 To: davidedmundson, #plasma, broulik Cc: ngraham, kde-frameworks-devel, michaelh, bruns
D15021: Workaround bug with native rendering and opacity in TextField text
broulik accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH origin-master (branched from master) REVISION DETAIL https://phabricator.kde.org/D15021 To: davidedmundson, #plasma, broulik Cc: kde-frameworks-devel, michaelh, ngraham, bruns
D15021: Workaround bug with native rendering and opacity in TextField text
davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. davidedmundson requested review of this revision. REVISION SUMMARY Problem is identified in https://bugreports.qt.io/browse/QTBUG-70138 with a potential patch for upstream. With native rendering the alpha is pointlessly also set in the glBlendFunc despite also being used in the uniform of the shader. Resulting in a visual bug when used on a window with alpha (such as Dialog) It sucks, but we were starting to see people work round it by copying more invasive workarounds everywhere else which I want to avoid. BUG: 396813 TEST PLAN Looked at a text field REPOSITORY R242 Plasma Framework (Library) BRANCH origin-master (branched from master) REVISION DETAIL https://phabricator.kde.org/D15021 AFFECTED FILES src/declarativeimports/plasmastyle/TextFieldStyle.qml To: davidedmundson, #plasma Cc: kde-frameworks-devel, michaelh, ngraham, bruns
