D15081: replace own wildcard matcher with QRegularExpression combining all wildcards add validator to index tool, only ? and * wildcard stuff is valid fix some syntax files that had e.g. , instead of
dhaumann added a comment. The old wildcard matcher existed for performance reasons. Did you check? PS: When doing review requests, could you please have a nice subject, and not put very long lines into its stead? :-p Especially since this line will also appear in Davids release notes? REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D15081 To: cullmann, vkrause, dhaumann Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, demsking, cullmann, sars, dhaumann
D15081: replace own wildcard matcher with QRegularExpression combining all wildcards add validator to index tool, only ? and * wildcard stuff is valid fix some syntax files that had e.g. , instead of
cullmann updated this revision to Diff 40429. cullmann added a comment. improve definitionForName code, already for matching take into account the priority that saves some matching time and avoid later sorting REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15081?vs=40428=40429 BRANCH master REVISION DETAIL https://phabricator.kde.org/D15081 AFFECTED FILES COPYING COPYING.LIB autotests/CMakeLists.txt autotests/definition_test.cpp autotests/syntaxrepository_test.cpp autotests/wildcardmatcher_test.cpp data/syntax/asterisk.xml data/syntax/gdbinit.xml data/syntax/gnuplot.xml data/syntax/pango.xml data/syntax/stata.xml src/indexer/katehighlightingindexer.cpp src/lib/CMakeLists.txt src/lib/definition.cpp src/lib/definition.h src/lib/definition_p.h src/lib/repository.cpp src/lib/wildcardmatcher.cpp src/lib/wildcardmatcher_p.h To: cullmann, vkrause, dhaumann Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, demsking, cullmann, sars, dhaumann
D15081: replace own wildcard matcher with QRegularExpression combining all wildcards add validator to index tool, only ? and * wildcard stuff is valid fix some syntax files that had e.g. , instead of
cullmann updated this revision to Diff 40428. cullmann added a comment. all code is now MIT only non-MIT parts are e.g. some generator scripts for highlighting and many highlighting data files REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15081?vs=40427=40428 BRANCH master REVISION DETAIL https://phabricator.kde.org/D15081 AFFECTED FILES COPYING COPYING.LIB autotests/CMakeLists.txt autotests/definition_test.cpp autotests/syntaxrepository_test.cpp autotests/wildcardmatcher_test.cpp data/syntax/asterisk.xml data/syntax/gdbinit.xml data/syntax/gnuplot.xml data/syntax/pango.xml data/syntax/stata.xml src/indexer/katehighlightingindexer.cpp src/lib/CMakeLists.txt src/lib/definition.cpp src/lib/definition.h src/lib/definition_p.h src/lib/repository.cpp src/lib/wildcardmatcher.cpp src/lib/wildcardmatcher_p.h To: cullmann, vkrause, dhaumann Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, demsking, cullmann, sars, dhaumann
D15081: replace own wildcard matcher with QRegularExpression combining all wildcards add validator to index tool, only ? and * wildcard stuff is valid fix some syntax files that had e.g. , instead of
cullmann added a comment. Rational for the static convertExtensionsToRegularExpression method: Allows to nice unit tests + allows e.g. KTextEditor to use that later, too, as replacement for its own copy of the wildcard matcher code for the modelines. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D15081 To: cullmann, vkrause, dhaumann Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, demsking, cullmann, sars, dhaumann
D15081: replace own wildcard matcher with QRegularExpression combining all wildcards add validator to index tool, only ? and * wildcard stuff is valid fix some syntax files that had e.g. , instead of
cullmann created this revision. cullmann added reviewers: vkrause, dhaumann. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. cullmann requested review of this revision. REVISION SUMMARY ...will never match as it tried to match the file path and is anyways 'very' basic add auto-test for new regex stuff TEST PLAN make && make test still works, autotest added REPOSITORY R216 Syntax Highlighting BRANCH master REVISION DETAIL https://phabricator.kde.org/D15081 AFFECTED FILES autotests/CMakeLists.txt autotests/definition_test.cpp autotests/syntaxrepository_test.cpp autotests/wildcardmatcher_test.cpp data/syntax/asterisk.xml data/syntax/gdbinit.xml data/syntax/gnuplot.xml data/syntax/pango.xml data/syntax/stata.xml src/indexer/katehighlightingindexer.cpp src/lib/CMakeLists.txt src/lib/definition.cpp src/lib/definition.h src/lib/definition_p.h src/lib/repository.cpp src/lib/wildcardmatcher.cpp src/lib/wildcardmatcher_p.h To: cullmann, vkrause, dhaumann Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, demsking, cullmann, sars, dhaumann
