D15125: Improve skip offset handling, allow to skip full line on no match
cullmann created this revision. cullmann added reviewers: vkrause, dhaumann. cullmann added a project: Framework: Syntax Highlighting. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. cullmann requested review of this revision. REVISION SUMMARY e.g. doMatch for regex stuff will use -1 as skipOffset. But -1 was not handled at all and you matched again and again. TEST PLAN make && make test works with patch: Totals: 132 passed, 0 failed, 0 skipped, 0 blacklisted, 2552ms - Finished testing of TestHighlighterTest * without patch: Totals: 132 passed, 0 failed, 0 skipped, 0 blacklisted, 3250ms - Finished testing of TestHighlighterTest * perf shows improvements, too, found during some AbsInt internal profiling .P REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D15125 AFFECTED FILES src/lib/abstracthighlighter.cpp To: cullmann, vkrause, dhaumann Cc: kwrite-devel, kde-frameworks-devel, bmortimer, michaelh, genethomas, kevinapavew, ngraham, bruns, demsking, cullmann, vkrause, sars, dhaumann
D15125: Improve skip offset handling, allow to skip full line on no match
vkrause accepted this revision. vkrause added a comment. This revision is now accepted and ready to land. Nice find! And a nice showcase of a contribution we wouldn't have gotten without MIT relicensing I guess :) REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D15125 To: cullmann, vkrause, dhaumann Cc: kwrite-devel, kde-frameworks-devel, bmortimer, michaelh, genethomas, kevinapavew, ngraham, bruns, demsking, cullmann, vkrause, sars, dhaumann
D15125: Improve skip offset handling, allow to skip full line on no match
cullmann added a comment. ;=) Yeah, given I can spend now some work-time on profiling things as we start to use the current master for our tools, I hope I can contribute some more things like this. A colleague has seen a massive slow-down compared to our old highlighter for some internal format and given it just has a few regex rules and a keyword list, this is a bit strange, need to see if this alone solves it. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D15125 To: cullmann, vkrause, dhaumann Cc: kwrite-devel, kde-frameworks-devel, bmortimer, michaelh, genethomas, kevinapavew, ngraham, bruns, demsking, cullmann, vkrause, sars, dhaumann
D15125: Improve skip offset handling, allow to skip full line on no match
This revision was automatically updated to reflect the committed changes. Closed by commit R216:184483443f4f: Improve skip offset handling, allow to skip full line on no match (authored by cullmann). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15125?vs=40557&id=40566 REVISION DETAIL https://phabricator.kde.org/D15125 AFFECTED FILES src/lib/abstracthighlighter.cpp To: cullmann, vkrause, dhaumann Cc: kwrite-devel, kde-frameworks-devel, bmortimer, michaelh, genethomas, kevinapavew, ngraham, bruns, demsking, cullmann, vkrause, sars, dhaumann
