D15194: Draw a line separating PlasmaComponents tab bar from its content area

[Nathaniel Graham]

ngraham created this revision.
ngraham added a reviewer: Plasma.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  This patch implements one of the ideas we came up with in D15011 
: a subtle line separating tab bars from 
their content areas.

TEST PLAN
  Tested with Kickoff and Plasma-pa with the panel on all four screen edges 
with the Breeze light and Breeze dark themes.
  
  [image goes here]

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  tabbar-separator-line (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D15194

AFFECTED FILES
  src/declarativeimports/plasmacomponents/qml/TabBar.qml

To: ngraham, #plasma
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15194: Draw a line separating PlasmaComponents tab bar from its content area

[Nathaniel Graham]

ngraham added a comment.


  I implemented this with the `horizontal-line`/`vertical-line` SVG items to 
follow the general pattern that I noticed, but I'm not super thrilled with the 
resulting legibility; it seems a bit too light, and was almost invisible at 1px 
tall. I also tried a 1px tall `Rectangle` which looked crisper, but I couldn't 
find a theme color that was light enough. Comments and suggestions welcome.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D15194

To: ngraham, #plasma
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15194: Draw a line separating PlasmaComponents tab bar from its content area

[Nathaniel Graham]

ngraham edited the summary of this revision.
ngraham edited the test plan for this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D15194

To: ngraham, #plasma
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15194: Draw a line separating PlasmaComponents tab bar from its content area

[Nathaniel Graham]

ngraham added a comment.


  Also, if it's preferable to position the item with anchors rather than 
specifying with x and y, I can do that too:
  
anchors {
left:   tabPosition == Qt.LeftEdge   ? undefined : buttonCutter.left
right:  tabPosition == Qt.RightEdge  ? undefined : buttonCutter.right
top:tabPosition == Qt.TopEdge? undefined : buttonCutter.top
bottom: tabPosition == Qt.BottomEdge ? undefined : buttonCutter.bottom
}

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D15194

To: ngraham, #plasma
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15194: Draw a line separating PlasmaComponents tab bar from its content area

[Nathaniel Graham]

ngraham added a reviewer: VDG.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D15194

To: ngraham, #plasma, #vdg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15194: Draw a line separating PlasmaComponents tab bar from its content area

[Andres Betts]

abetts added a comment.


  +1

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D15194

To: ngraham, #plasma, #vdg
Cc: abetts, kde-frameworks-devel, michaelh, ngraham, bruns

D15194: Draw a line separating PlasmaComponents tab bar from its content area

[Nathaniel Graham]

ngraham added a comment.


  So I've got a +1 from VDG. Any opinions from someone in #plasma 
?

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D15194

To: ngraham, #plasma, #vdg
Cc: abetts, kde-frameworks-devel, michaelh, ngraham, bruns

D15194: Draw a line separating PlasmaComponents tab bar from its content area

[Roman Gilg]

romangg added a comment.


  If there are more items than space available in the list a line is drawn 
already now to indicate that there are more items to come by scrolling down. 
Does this not conflict with the new line?

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D15194

To: ngraham, #plasma, #vdg
Cc: romangg, abetts, kde-frameworks-devel, michaelh, ngraham, bruns

D15194: Draw a line separating PlasmaComponents tab bar from its content area

[Andres Betts]

abetts added a comment.


  In D15194#328651 , @romangg wrote:
  
  > If there are more items than space available in the list a line is drawn 
already now to indicate that there are more items to come by scrolling down. 
Does this not conflict with the new line?
  
  
  Screenshot?

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D15194

To: ngraham, #plasma, #vdg
Cc: romangg, abetts, kde-frameworks-devel, michaelh, ngraham, bruns

D15194: Draw a line separating PlasmaComponents tab bar from its content area

[Nathaniel Graham]

ngraham planned changes to this revision.
ngraham added a comment.


  In D15194#328915 , @abetts wrote:
  
  > In D15194#328651 , @romangg 
wrote:
  >
  > > If there are more items than space available in the list a line is drawn 
already now to indicate that there are more items to come by scrolling down. 
Does this not conflict with the new line?
  >
  >
  > Screenshot?
  
  
  F6286411: how it looks.png 
  
  I'll move the lines a pixel or two so that they touch the ones drawn by the 
ScrollView.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D15194

To: ngraham, #plasma, #vdg
Cc: romangg, abetts, kde-frameworks-devel, michaelh, ngraham, bruns

D15194: Draw a line separating PlasmaComponents tab bar from its content area

[Nathaniel Graham]

ngraham updated this revision to Diff 42763.
ngraham added a comment.


  Make the separator line touch the line drawn by the scrollview when it's 
scrollable

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15194?vs=40798&id=42763

BRANCH
  tabbar-separator-line (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D15194

AFFECTED FILES
  src/declarativeimports/plasmacomponents/qml/TabBar.qml

To: ngraham, #plasma, #vdg
Cc: romangg, abetts, kde-frameworks-devel, michaelh, ngraham, bruns

D15194: Draw a line separating PlasmaComponents tab bar from its content area

[Dominik Haumann]

dhaumann added a comment.


  Hm, two separator lines, even touching each other sounds like a hack. Is 
there no better way?

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D15194

To: ngraham, #plasma, #vdg
Cc: dhaumann, romangg, abetts, kde-frameworks-devel, michaelh, ngraham, bruns

D15194: Draw a line separating PlasmaComponents tab bar from its content area

[Nathaniel Graham]

ngraham abandoned this revision.
ngraham added a comment.


  Not needed; we can and arguably should do all of this only in Kickoff since 
this style isn't guaranteed to look good everywhere. We'll do everything in 
D15206 .

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D15194

To: ngraham, #plasma, #vdg
Cc: dhaumann, romangg, abetts, kde-frameworks-devel, michaelh, ngraham, bruns