D15283: Move SMB KCM to Network Settings category

[Kai Uwe Broulik]

This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R241:ace6f726eaf5: Move SMB KCM to Network Settings category 
(authored by broulik).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15283?vs=41022=41132

REVISION DETAIL
  https://phabricator.kde.org/D15283

AFFECTED FILES
  src/kcms/kio/smb.desktop

To: broulik, #frameworks, #vdg
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D15283: Move SMB KCM to Network Settings category

[Nathaniel Graham]

ngraham accepted this revision as: VDG.
ngraham added a comment.


  OK, for now let's move it to the proper place then.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D15283

To: broulik, #frameworks, #vdg
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D15283: Move SMB KCM to Network Settings category

[Kai Uwe Broulik]

broulik added a comment.


  I investigated once but the SMB kio slave actually still reads these 
properties. Why it doesn't work, I have no idea. SMB browsing is completely 
broken in newer distros thanks to switch to SMB >= 2 ..

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D15283

To: broulik, #frameworks, #vdg
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D15283: Move SMB KCM to Network Settings category

[Nathaniel Graham]

ngraham added a comment.


  Makes sense, but can we just delete this KCM entirely instead? Apparently it 
doesn't, um, work. https://bugs.kde.org/show_bug.cgi?id=164283

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D15283

To: broulik, #frameworks, #vdg
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D15283: Move SMB KCM to Network Settings category

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: Frameworks, VDG.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
broulik requested review of this revision.

REVISION SUMMARY
  The "Connectivity" category is empty and makes it show up on the root level 
as non-descript "Connectivity" entry

TEST PLAN
  Before
  F6236479: Screenshot_20180905_093102.png 

  After
  F6236480: Screenshot_20180905_093159.png 

  Every other KIO KCM is also in that category

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D15283

AFFECTED FILES
  src/kcms/kio/smb.desktop

To: broulik, #frameworks, #vdg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns