D15851: Fix signals not being emitted when merging two persons

2018-10-01 Thread Igor Poboiko
poboiko closed this revision.

REPOSITORY
  R307 KPeople

REVISION DETAIL
  https://phabricator.kde.org/D15851

To: poboiko, #frameworks, dvratil
Cc: kde-frameworks-devel, michaelh, ngraham, bruns


D15851: Fix signals not being emitted when merging two persons

2018-10-01 Thread Daniel Vrátil
dvratil accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R307 KPeople

BRANCH
  forgotten-signal (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D15851

To: poboiko, #frameworks, dvratil
Cc: kde-frameworks-devel, michaelh, ngraham, bruns


D15851: Fix signals not being emitted when merging two persons

2018-09-30 Thread Igor Poboiko
poboiko created this revision.
poboiko added reviewers: Frameworks, dvratil.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
poboiko requested review of this revision.

REVISION SUMMARY
  If I have 4 contacts, i.e. `{A,B,C,D}`, then merge `{A,B}->1` and `{C,D}->2`, 
and then merge `{1,2}->1`,
  inside the model I get only signals that contacts `{C,D}` were removed from 
person `2`, ending up with 3 contacts in the model `{1,C,D}`, instead of just 
`1`.
  Apparently, the line was simply missing.

TEST PLAN
  With this patch, merging works as expected

REPOSITORY
  R307 KPeople

BRANCH
  forgotten-signal (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D15851

AFFECTED FILES
  src/personmanager.cpp

To: poboiko, #frameworks, dvratil
Cc: kde-frameworks-devel, michaelh, ngraham, bruns