D15873: Improve debugging output by displaying whether the SMBSlave::del() function attempts to delete a file or a directory.

2018-10-08 Thread Michal Malý 
This revision was automatically updated to reflect the committed changes.
Closed by commit R320:a26de31a5dfb: Distinguish between file and directory 
delete request in debug output. (authored by madcatx).

REPOSITORY
  R320 KIO Extras

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15873?vs=42646=43120

REVISION DETAIL
  https://phabricator.kde.org/D15873

AFFECTED FILES
  smb/kio_smb_dir.cpp

To: madcatx, elvisangelaccio, broulik
Cc: ngraham, kde-frameworks-devel, kfm-devel, feverfew, michaelh, spoorun, 
navarromorales, firef, andrebarros, bruns, emmanuelp

D15873: Improve debugging output by displaying whether the SMBSlave::del() function attempts to delete a file or a directory.

2018-10-02 Thread Nathaniel Graham 
ngraham added a comment.


  Read this 
https://community.kde.org/Infrastructure/Get_a_Developer_Account#Who_Can_Apply_For_a_KDE_Developer_Account.3F
 and then go here: https://identity.kde.org/index.php?r=developerApplication

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D15873

To: madcatx, elvisangelaccio, broulik
Cc: ngraham, kde-frameworks-devel, kfm-devel, feverfew, michaelh, spoorun, 
navarromorales, firef, andrebarros, bruns, emmanuelp

D15873: Improve debugging output by displaying whether the SMBSlave::del() function attempts to delete a file or a directory.

2018-10-02 Thread Michal Malý 
madcatx added a comment.


  @elvisangelaccio: OK, what do I have to do?

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D15873

To: madcatx, elvisangelaccio, broulik
Cc: kde-frameworks-devel, kfm-devel, feverfew, michaelh, spoorun, 
navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp

D15873: Improve debugging output by displaying whether the SMBSlave::del() function attempts to delete a file or a directory.

2018-10-01 Thread Elvis Angelaccio 
elvisangelaccio accepted this revision.
elvisangelaccio added a comment.


  @madcatx Time to request commit access? :D

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D15873

To: madcatx, elvisangelaccio, broulik
Cc: kde-frameworks-devel, kfm-devel, feverfew, michaelh, spoorun, 
navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp

D15873: Improve debugging output by displaying whether the SMBSlave::del() function attempts to delete a file or a directory.

2018-10-01 Thread Kai Uwe Broulik 
broulik accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D15873

To: madcatx, elvisangelaccio, broulik
Cc: kde-frameworks-devel, kfm-devel, feverfew, michaelh, spoorun, 
navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp

D15873: Improve debugging output by displaying whether the SMBSlave::del() function attempts to delete a file or a directory.

2018-10-01 Thread Michal Malý 
madcatx created this revision.
madcatx added a reviewer: elvisangelaccio.
Herald added projects: Dolphin, Frameworks.
Herald added subscribers: kfm-devel, kde-frameworks-devel.
madcatx requested review of this revision.

REVISION SUMMARY
  This has proven to be useful while I was tracking down what seems like a 
glitch in libsmbclient.
  
  Relevant Samba bug report: https://bugzilla.samba.org/show_bug.cgi?id=13637

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D15873

AFFECTED FILES
  smb/kio_smb_dir.cpp

To: madcatx, elvisangelaccio
Cc: kde-frameworks-devel, kfm-devel, feverfew, michaelh, spoorun, 
navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp