D16091: Added missing Icons to Places Panel code from KIO

2018-10-09 Thread Nathaniel Graham 
ngraham closed this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D16091

To: alexde, ngraham
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16091: Added missing Icons to Places Panel code from KIO

2018-10-09 Thread Nathaniel Graham 
ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Perfect, thanks! Since you submitted a new revision rather than updating 
D16049 , you'll want to formally Abandon 
that one. In the future, now that you have `arc` set up, to update an existing 
patch, just do `arc diff` when you're on the branch for that patch.

REPOSITORY
  R241 KIO

BRANCH
  missingIcons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D16091

To: alexde, ngraham
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16091: Added missing Icons to Places Panel code from KIO

2018-10-09 Thread Alex Debus 
alexde created this revision.
alexde added a reviewer: ngraham.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
alexde requested review of this revision.

REVISION SUMMARY
  The items "Hide", "Hide Entry" and "Show All Entries" of the places panel did 
not have icons.
  Therefor I replicated the changes for the KIO code, which I already submitted 
for Dolphin.

REPOSITORY
  R241 KIO

BRANCH
  missingIcons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D16091

AFFECTED FILES
  src/filewidgets/kfileplacesview.cpp

To: alexde, ngraham
Cc: kde-frameworks-devel, michaelh, ngraham, bruns