D16179: compare with QLatin1String and harmonize handling of all types

2018-10-17 Thread Alexander Stippich 
This revision was automatically updated to reflect the committed changes.
Closed by commit R286:fd9ce3a4e1d2: compare with QLatin1String and harmonize 
handling of all types (authored by astippich).

REPOSITORY
  R286 KFileMetaData

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16179?vs=43546=43818

REVISION DETAIL
  https://phabricator.kde.org/D16179

AFFECTED FILES
  src/extractors/taglibextractor.cpp

To: astippich, mgallien, bruns
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D16179: compare with QLatin1String and harmonize handling of all types

2018-10-17 Thread Alexander Stippich 
astippich added a comment.


  Ok. Thanks!

REPOSITORY
  R286 KFileMetaData

BRANCH
  harmonize_optimize

REVISION DETAIL
  https://phabricator.kde.org/D16179

To: astippich, mgallien, bruns
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D16179: compare with QLatin1String and harmonize handling of all types

2018-10-17 Thread Stefan Brüns 
bruns accepted this revision.
bruns added a comment.
This revision is now accepted and ready to land.


  Preferably, do such independent changes (restructuring, coding 
style/optimization) as two separate reviews.

REPOSITORY
  R286 KFileMetaData

BRANCH
  harmonize_optimize

REVISION DETAIL
  https://phabricator.kde.org/D16179

To: astippich, mgallien, bruns
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D16179: compare with QLatin1String and harmonize handling of all types

2018-10-13 Thread Alexander Stippich 
astippich created this revision.
astippich added reviewers: mgallien, bruns.
Herald added projects: Frameworks, Baloo.
Herald added subscribers: Baloo, kde-frameworks-devel.
astippich requested review of this revision.

REVISION SUMMARY
  small optimization and harmonization for all metadata formats in 
taglibextractor

REPOSITORY
  R286 KFileMetaData

BRANCH
  harmonize_optimize

REVISION DETAIL
  https://phabricator.kde.org/D16179

AFFECTED FILES
  src/extractors/taglibextractor.cpp

To: astippich, mgallien, bruns
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams