D16281: update epub test data and test for comment property

2018-10-28 Thread Alexander Stippich 
This revision was automatically updated to reflect the committed changes.
Closed by commit R286:d97b15679179: update epub test data and test for comment 
property (authored by astippich).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D16281?vs=43887&id=44364#toc

REPOSITORY
  R286 KFileMetaData

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16281?vs=43887&id=44364

REVISION DETAIL
  https://phabricator.kde.org/D16281

AFFECTED FILES
  autotests/epubextractortest.cpp
  autotests/samplefiles/test.epub

To: astippich, bruns
Cc: cfeck, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, 
spoorun, ngraham, bruns, abrahams

D16281: update epub test data and test for comment property

2018-10-28 Thread Stefan Brüns 
bruns accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R286 KFileMetaData

BRANCH
  description_test_preparation

REVISION DETAIL
  https://phabricator.kde.org/D16281

To: astippich, bruns
Cc: cfeck, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, 
spoorun, ngraham, bruns, abrahams

D16281: update epub test data and test for comment property

2018-10-18 Thread Alexander Stippich 
astippich updated this revision to Diff 43887.
astippich added a comment.


  - fix test file

REPOSITORY
  R286 KFileMetaData

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16281?vs=43820&id=43887

BRANCH
  description_test_preparation

REVISION DETAIL
  https://phabricator.kde.org/D16281

AFFECTED FILES
  autotests/epubextractortest.cpp
  autotests/samplefiles/test.epub

To: astippich, bruns
Cc: cfeck, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, 
spoorun, ngraham, bruns, abrahams

D16281: update epub test data and test for comment property

2018-10-17 Thread Stefan Brüns 
bruns added a comment.


  In D16281#344995 , @cfeck wrote:
  
  > Phabricator says the MIME Type was changed from application/epub+zip to 
application/zip. Is this a problem in Phabricator or in your file?
  
  
  The file no longer is spec compliant, as the first file in the zip container 
has to be the "mimetype" file, see OPF 
.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D16281

To: astippich, bruns
Cc: cfeck, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, 
spoorun, ngraham, bruns, abrahams

D16281: update epub test data and test for comment property

2018-10-17 Thread Stefan Brüns 
bruns requested changes to this revision.
This revision now requires changes to proceed.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D16281

To: astippich, bruns
Cc: cfeck, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, 
spoorun, ngraham, bruns, abrahams

D16281: update epub test data and test for comment property

2018-10-17 Thread Christoph Feck 
cfeck added a comment.


  Phabricator says the MIME Type was changed from application/epub+zip to 
application/zip. Is this is problem in Phabricator or in your file?

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D16281

To: astippich, bruns
Cc: cfeck, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, 
spoorun, ngraham, bruns, abrahams

D16281: update epub test data and test for comment property

2018-10-17 Thread Alexander Stippich 
astippich added a comment.


  In preparation of D12114 , which I plan 
to commandeer

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D16281

To: astippich, bruns
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D16281: update epub test data and test for comment property

2018-10-17 Thread Alexander Stippich 
astippich created this revision.
astippich added a reviewer: bruns.
Herald added projects: Frameworks, Baloo.
Herald added subscribers: Baloo, kde-frameworks-devel.
astippich requested review of this revision.

REVISION SUMMARY
  update the test data for epub and test for
  the comment property in the epub autotest

REPOSITORY
  R286 KFileMetaData

BRANCH
  description_test_preparation

REVISION DETAIL
  https://phabricator.kde.org/D16281

AFFECTED FILES
  autotests/epubextractortest.cpp
  autotests/samplefiles/test.epub

To: astippich, bruns
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams