D16295: Remove PLASMA_NO_KIO

2018-10-18 Thread Kai Uwe Broulik 
This revision was automatically updated to reflect the committed changes.
Closed by commit R242:e92ed94d9d1a: Remove PLASMA_NO_KIO option (authored by 
broulik).

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16295?vs=43857&id=43872

REVISION DETAIL
  https://phabricator.kde.org/D16295

AFFECTED FILES
  autotests/CMakeLists.txt
  src/plasma/CMakeLists.txt
  src/plasma/config-plasma.h.cmake
  src/plasma/containment.cpp
  src/plasma/pluginloader.cpp
  src/plasma/private/associatedapplicationmanager.cpp
  src/scriptengines/qml/CMakeLists.txt
  src/scriptengines/qml/plasmoid/containmentinterface.cpp

To: broulik, #plasma, mart, davidedmundson
Cc: davidedmundson, kde-frameworks-devel, michaelh, ngraham, bruns

D16295: Remove PLASMA_NO_KIO

2018-10-18 Thread David Edmundson 
davidedmundson accepted this revision.
davidedmundson added a comment.
This revision is now accepted and ready to land.


  ++

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D16295

To: broulik, #plasma, mart, davidedmundson
Cc: davidedmundson, kde-frameworks-devel, michaelh, ngraham, bruns

D16295: Remove PLASMA_NO_KIO

2018-10-18 Thread Kai Uwe Broulik 
broulik created this revision.
broulik added reviewers: Plasma, mart.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
broulik requested review of this revision.

REVISION SUMMARY
  It is a remnant of the Active days and didn't even compile.
  This patch only removes those ifdefs, it doesn't fix any issues I found 
during (e.g. double lookups or the fact that `KRun::autoDelete` is the default 
now)

TEST PLAN
  I think the entire `KDE_PLATFORM_FEATURE_BINARY_COMPATIBLE_FEATURE_REDUCTION` 
could be removed, but one step at a time
  
  Compiles, dropping files on desktop still asks what do to and adding a widget 
or setting as wallpaper works

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D16295

AFFECTED FILES
  autotests/CMakeLists.txt
  src/plasma/CMakeLists.txt
  src/plasma/config-plasma.h.cmake
  src/plasma/containment.cpp
  src/plasma/pluginloader.cpp
  src/plasma/private/associatedapplicationmanager.cpp
  src/scriptengines/qml/CMakeLists.txt
  src/scriptengines/qml/plasmoid/containmentinterface.cpp

To: broulik, #plasma, mart
Cc: kde-frameworks-devel, michaelh, ngraham, bruns