D16405: Add debug category for bookmarks runner

2018-10-24 Thread Stefan Brüns 
bruns added a dependent revision: D16409: [Bookmarks Runner] Open database 
connection in the query thread.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D16405

To: bruns, #frameworks, davidedmundson
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D16405: Add debug category for bookmarks runner

2018-10-24 Thread Stefan Brüns 
bruns added a comment.


  Only applies cleanly after D16403 .

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D16405

To: bruns, #frameworks, davidedmundson
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D16405: Add debug category for bookmarks runner

2018-10-24 Thread Stefan Brüns 
bruns added a dependency: D16403: Add services and appstream runner debug 
categories to categories file.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D16405

To: bruns, #frameworks, davidedmundson
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D16405: Add debug category for bookmarks runner

2018-10-24 Thread Stefan Brüns 
bruns added a comment.


  Depends on the cleanup in D16404 , as the 
autogenerated `bookmarks_debug.cpp` is not linked to the 
tests/testChromeBookmarks binary otherwise.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D16405

To: bruns, #frameworks, davidedmundson
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D16405: Add debug category for bookmarks runner

2018-10-24 Thread Stefan Brüns 
bruns added a dependency: D16404: [Bookmarks Runner] Cleanup tests CMakeList.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D16405

To: bruns, #frameworks, davidedmundson
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D16405: Add debug category for bookmarks runner

2018-10-24 Thread David Edmundson 
davidedmundson accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D16405

To: bruns, #frameworks, davidedmundson
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D16405: Add debug category for bookmarks runner

2018-10-24 Thread Stefan Brüns 
bruns created this revision.
bruns added a reviewer: Frameworks.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
bruns requested review of this revision.

REVISION SUMMARY
  Dependency for followup patches, no functional change

TEST PLAN
  make

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D16405

AFFECTED FILES
  plasma-workspace.categories
  runners/bookmarks/CMakeLists.txt

To: bruns, #frameworks
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart