D16772: Add new icons for root

2018-11-09 Thread Nathaniel Graham 
This revision was automatically updated to reflect the committed changes.
Closed by commit R266:e2270613fc25: Add new icons for root (authored by ndavis, 
committed by ngraham).

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16772?vs=45209=45213

REVISION DETAIL
  https://phabricator.kde.org/D16772

AFFECTED FILES
  icons-dark/devices/16/drive-harddisk-root.svg
  icons-dark/devices/22/drive-harddisk-root.svg
  icons-dark/devices/64/drive-harddisk-root.svg
  icons-dark/devices/symbolic/drive-harddisk-root-symbolic.svg
  icons-dark/places/16/folder-root.svg
  icons-dark/places/22/folder-root.svg
  icons-dark/places/32/folder-root.svg
  icons-dark/places/64/folder-root.svg
  icons-dark/places/symbolic/folder-root-symbolic.svg
  icons/devices/16/drive-harddisk-root.svg
  icons/devices/22/drive-harddisk-root.svg
  icons/devices/64/drive-harddisk-root.svg
  icons/devices/symbolic/drive-harddisk-root-symbolic.svg
  icons/places/16/folder-root.svg
  icons/places/22/folder-root.svg
  icons/places/32/folder-root.svg
  icons/places/64/folder-root.svg
  icons/places/symbolic/folder-root-symbolic.svg

To: ndavis, #vdg, ngraham
Cc: ngraham, #vdg, kde-frameworks-devel, michaelh, bruns

D16772: Add new icons for root

2018-11-09 Thread Nathaniel Graham 
ngraham added a comment.


  Other VDG folks in chat seem happy as well. Landing it!
  
  Nice work.

REPOSITORY
  R266 Breeze Icons

BRANCH
  folder-root (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D16772

To: ndavis, #vdg, ngraham
Cc: ngraham, #vdg, kde-frameworks-devel, michaelh, bruns

D16772: Add new icons for root

2018-11-09 Thread Nathaniel Graham 
ngraham added a comment.


  Usually the time is right when someone recommends that you do so! :-)

REPOSITORY
  R266 Breeze Icons

BRANCH
  folder-root (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D16772

To: ndavis, #vdg, ngraham
Cc: ngraham, #vdg, kde-frameworks-devel, michaelh, bruns

D16772: Add new icons for root

2018-11-09 Thread Noah Davis 
ndavis added a comment.


  In D16772#357086 , @ngraham wrote:
  
  > Makes sense to me. Now that I see them all together, I agree that /_ is a 
bit better. It seems much better for the folder, and at least no worse (and 
probably a bit better) for the disk.
  >
  > Any other VDG comments, or should we land this?
  >
  > BTW, @ndavis, you're doing so much good work that I would recommend you 
apply for a Developer account so you can land your own patches. You can read 
about that here: 
https://community.kde.org/Infrastructure/Get_a_Developer_Account
  >
  > BTW, once this goes in, I'll submit a KIO patch to use the new icon for the 
current Root Places Panel item. If we end up not removing it after all, we 
might as well use the nice new icon! :)
  
  
  Thanks! I've been thinking about when I should get a developer account.

REPOSITORY
  R266 Breeze Icons

BRANCH
  folder-root (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D16772

To: ndavis, #vdg, ngraham
Cc: ngraham, #vdg, kde-frameworks-devel, michaelh, bruns

D16772: Add new icons for root

2018-11-09 Thread Noah Davis 
ndavis updated this revision to Diff 45208.
ndavis added a comment.


  Update commit message to more accurately describe the changes

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16772?vs=45196=45208

BRANCH
  folder-root (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D16772

AFFECTED FILES
  icons-dark/devices/16/drive-harddisk-root.svg
  icons-dark/devices/22/drive-harddisk-root.svg
  icons-dark/devices/64/drive-harddisk-root.svg
  icons-dark/places/16/folder-root.svg
  icons-dark/places/22/folder-root.svg
  icons-dark/places/32/folder-root.svg
  icons-dark/places/64/folder-root.svg
  icons-dark/places/symbolic/folder-root-symbolic.svg
  icons/devices/16/drive-harddisk-root.svg
  icons/devices/22/drive-harddisk-root.svg
  icons/devices/64/drive-harddisk-root.svg
  icons/places/16/folder-root.svg
  icons/places/22/folder-root.svg
  icons/places/32/folder-root.svg
  icons/places/64/folder-root.svg
  icons/places/symbolic/folder-root-symbolic.svg

To: ndavis, #vdg, ngraham
Cc: ngraham, #vdg, kde-frameworks-devel, michaelh, bruns

D16772: Add new icons for root

2018-11-09 Thread Noah Davis 
ndavis updated this revision to Diff 45196.
ndavis added a comment.


  Change style to `/_`. The reason for this is that `/` by itself looks kind of 
empty and it's easy to confuse the meaning with disabled or inactive, 
especially for drive-harddisk-root.

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16772?vs=45150=45196

BRANCH
  folder-root (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D16772

AFFECTED FILES
  icons-dark/devices/16/drive-harddisk-root.svg
  icons-dark/devices/22/drive-harddisk-root.svg
  icons-dark/devices/64/drive-harddisk-root.svg
  icons-dark/places/16/folder-root.svg
  icons-dark/places/22/folder-root.svg
  icons-dark/places/32/folder-root.svg
  icons-dark/places/64/folder-root.svg
  icons-dark/places/symbolic/folder-root-symbolic.svg
  icons/devices/16/drive-harddisk-root.svg
  icons/devices/22/drive-harddisk-root.svg
  icons/devices/64/drive-harddisk-root.svg
  icons/places/16/folder-root.svg
  icons/places/22/folder-root.svg
  icons/places/32/folder-root.svg
  icons/places/64/folder-root.svg
  icons/places/symbolic/folder-root-symbolic.svg

To: ndavis, #vdg
Cc: #vdg, kde-frameworks-devel, michaelh, ngraham, bruns

D16772: Add new icons for root

2018-11-09 Thread Noah Davis 
ndavis retitled this revision from "Add folder-root icon" to "Add new icons for 
root".
ndavis edited the summary of this revision.
ndavis edited the test plan for this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D16772

To: ndavis, #vdg
Cc: #vdg, kde-frameworks-devel, michaelh, ngraham, bruns