D17084: Prolog & Lua: fix shebang
dhaumann added a comment. Btw, I think in this case the fix is correct. But sometimes, detecting a Shebang in an extra context introduces regressions when the language is used in other xml files via IncludeRules. This seems not the case here, though, so all is fine. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D17084 To: nibags, #framework_syntax_highlighting, cullmann, dhaumann Cc: kwrite-devel, kde-frameworks-devel, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann
D17084: Prolog & Lua: fix shebang
This revision was automatically updated to reflect the committed changes. Closed by commit R216:6f109cf88198: Prolog Lua: fix shebang (authored by nibags, committed by cullmann). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17084?vs=45991=46137 REVISION DETAIL https://phabricator.kde.org/D17084 AFFECTED FILES autotests/folding/test.prolog.fold autotests/html/test.prolog.html autotests/input/test.prolog autotests/reference/test.prolog.ref data/syntax/lua.xml data/syntax/prolog.xml To: nibags, #framework_syntax_highlighting, cullmann, dhaumann Cc: kwrite-devel, kde-frameworks-devel, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann
D17084: Prolog & Lua: fix shebang
cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. Looks reasonable, has tests, will be applied, thanks! REPOSITORY R216 Syntax Highlighting BRANCH fix-shebang REVISION DETAIL https://phabricator.kde.org/D17084 To: nibags, #framework_syntax_highlighting, cullmann, dhaumann Cc: kwrite-devel, kde-frameworks-devel, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann
D17084: Prolog & Lua: fix shebang
nibags updated this revision to Diff 45991. nibags added a comment. - Add tests REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17084?vs=45973=45991 BRANCH fix-shebang REVISION DETAIL https://phabricator.kde.org/D17084 AFFECTED FILES autotests/folding/test.prolog.fold autotests/html/test.prolog.html autotests/input/test.prolog autotests/reference/test.prolog.ref data/syntax/lua.xml data/syntax/prolog.xml To: nibags, #framework_syntax_highlighting, cullmann, dhaumann Cc: kwrite-devel, kde-frameworks-devel, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann
D17084: Prolog & Lua: fix shebang
nibags added reviewers: Framework: Syntax Highlighting, cullmann, dhaumann. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D17084 To: nibags, #framework_syntax_highlighting, cullmann, dhaumann Cc: kwrite-devel, kde-frameworks-devel, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann
D17084: Prolog & Lua: fix shebang
nibags created this revision. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. nibags requested review of this revision. REVISION SUMMARY Before, the shebang was highlighted if there were empty lines before. Now it will only be highlighted in the first line. REPOSITORY R216 Syntax Highlighting BRANCH fix-shebang REVISION DETAIL https://phabricator.kde.org/D17084 AFFECTED FILES data/syntax/lua.xml data/syntax/prolog.xml To: nibags Cc: kwrite-devel, kde-frameworks-devel, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann
