D17305: Add KDE Connect SMS plugin
This revision was automatically updated to reflect the committed changes. Closed by commit R495:617e09707f0f: Add KDE Connect SMS plugin (authored by nicolasfella). REPOSITORY R495 Purpose Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17305?vs=47226&id=53547 REVISION DETAIL https://phabricator.kde.org/D17305 AFFECTED FILES src/plugins/CMakeLists.txt src/plugins/kdeconnect_sms/CMakeLists.txt src/plugins/kdeconnect_sms/Messages.sh src/plugins/kdeconnect_sms/kdeconnectsmsplugin.cpp src/plugins/kdeconnect_sms/kdeconnectsmsplugin.json To: nicolasfella, apol Cc: kde-frameworks-devel, michaelh, ngraham, bruns
D17305: Add KDE Connect SMS plugin
apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R495 Purpose Library BRANCH kdeconnectsms REVISION DETAIL https://phabricator.kde.org/D17305 To: nicolasfella, apol Cc: kde-frameworks-devel, michaelh, ngraham, bruns
D17305: Add KDE Connect SMS plugin
nicolasfella updated this revision to Diff 47226. nicolasfella added a comment. - i18n REPOSITORY R495 Purpose Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17305?vs=46697&id=47226 BRANCH kdeconnectsms REVISION DETAIL https://phabricator.kde.org/D17305 AFFECTED FILES src/plugins/CMakeLists.txt src/plugins/kdeconnect_sms/CMakeLists.txt src/plugins/kdeconnect_sms/Messages.sh src/plugins/kdeconnect_sms/kdeconnectsmsplugin.cpp src/plugins/kdeconnect_sms/kdeconnectsmsplugin.json To: nicolasfella, apol Cc: kde-frameworks-devel, michaelh, ngraham, bruns
D17305: Add KDE Connect SMS plugin
apol added inline comments.
INLINE COMMENTS
> kdeconnectsmsplugin.cpp:51
> +QString title = data().value(QStringLiteral("title")).toString();
> +QString message = QStringLiteral("%1 -
> %2").arg(title).arg(arrayToList(urlsJson).join(QLatin1Char(' ')));
> +
i18n? Thinking of RTL languages.
REPOSITORY
R495 Purpose Library
REVISION DETAIL
https://phabricator.kde.org/D17305
To: nicolasfella, apol
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
D17305: Add KDE Connect SMS plugin
nicolasfella edited the summary of this revision. nicolasfella added a dependency: D17285: Add plugin type for sharing URLs. REPOSITORY R495 Purpose Library REVISION DETAIL https://phabricator.kde.org/D17305 To: nicolasfella, apol Cc: kde-frameworks-devel, michaelh, ngraham, bruns
D17305: Add KDE Connect SMS plugin
nicolasfella edited the summary of this revision. nicolasfella added a dependency: D17292: [SMS App] Allow passing a message via args. REPOSITORY R495 Purpose Library REVISION DETAIL https://phabricator.kde.org/D17305 To: nicolasfella, apol Cc: kde-frameworks-devel, michaelh, ngraham, bruns
D17305: Add KDE Connect SMS plugin
nicolasfella created this revision. nicolasfella added a reviewer: apol. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. nicolasfella requested review of this revision. REVISION SUMMARY Enable sharing links via KDE Connect SMS TEST PLAN Send a page from Falkon via SMS REPOSITORY R495 Purpose Library BRANCH kdeconnectsms REVISION DETAIL https://phabricator.kde.org/D17305 AFFECTED FILES src/plugins/CMakeLists.txt src/plugins/kdeconnect_sms/CMakeLists.txt src/plugins/kdeconnect_sms/Messages.sh src/plugins/kdeconnect_sms/kdeconnectsmsplugin.cpp src/plugins/kdeconnect_sms/kdeconnectsmsplugin.json To: nicolasfella, apol Cc: kde-frameworks-devel, michaelh, ngraham, bruns
