D17372: [componentchooser KCM] Make KIO browser option the fallback only and remove from the UI

[Nathaniel Graham]

ngraham abandoned this revision.
ngraham added a comment.


  Abandoning in favor of those patches. Thanks @meven!

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D17372

To: ngraham, #plasma, #vdg, #frameworks, dfaure
Cc: meven, GB_2, dfaure, abetts, davidedmundson, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, 
alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, 
ahiemstra, mart

D17372: [componentchooser KCM] Make KIO browser option the fallback only and remove from the UI

[Méven Car]

meven added a comment.


  In D17372#472624 , @dfaure wrote:
  
  > Writing into the user's home dir is a "hack".
  >
  > There are better ways for distros to set defaults (such as the global 
mimeapps.list) but it seems KIO ignores that... (to be checked...)
  
  
  It did (did not read `[Default Applications] x-scheme-handle/http` basicaly.
  I have a fix for that : D26690 
  
  And I have another go at this UI : D26731 

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D17372

To: ngraham, #plasma, #vdg, #frameworks, dfaure
Cc: meven, GB_2, dfaure, abetts, davidedmundson, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, 
alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, 
ahiemstra, mart

D17372: [componentchooser KCM] Make KIO browser option the fallback only and remove from the UI

[David Faure]

dfaure added a comment.


  Writing into the user's home dir is a "hack".
  
  There are better ways for distros to set defaults (such as the global 
mimeapps.list) but it seems KIO ignores that... (to be checked...)

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D17372

To: ngraham, #plasma, #vdg, #frameworks, dfaure
Cc: GB_2, dfaure, abetts, davidedmundson, plasma-devel, jraleigh, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, 
mart

D17372: [componentchooser KCM] Make KIO browser option the fallback only and remove from the UI

[Nathaniel Graham]

ngraham planned changes to this revision.
ngraham added a comment.


  I don't think it's a "distro hack" to set a default browser, which is why 
they all do it. Not having a default browser set seems like an error condition 
to me. However I see what you meanabout the bugginess and will work on it.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D17372

To: ngraham, #plasma, #vdg, #frameworks, dfaure
Cc: GB_2, dfaure, abetts, davidedmundson, plasma-devel, jraleigh, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, 
mart

D17372: [componentchooser KCM] Make KIO browser option the fallback only and remove from the UI

[David Faure]

dfaure requested changes to this revision.
dfaure added a comment.
This revision now requires changes to proceed.


  I agree that we shouldn't remove the underlying feature, in fact it's still 
used on other protocols than http.
  
  But we have to ensure the default behaviour matches the KCM and vice-versa, 
for http.

INLINE COMMENTS

> componentchooserbrowser.cpp:68
> +if (browserCombo->count() > 0) {
> +const QString  = 
> browserCombo->currentData().toString();
> +m_browserService = KService::serviceByStorageId(storageId);

This will lead to rather confusing user experience, btw.

On a freshly installed system [without distro hacks], BrowserApplication is 
empty.
In practice that means KRun::setEnableExternalBrowser will pick the entry 
x-scheme-handler/https in the user's mimeapps.list, if any. And if that isn't 
set either, then well, the current behaviour in KRun, AFAICS, *will* be to use 
KIO to find out the mimetype.

Then the user opens this KCM, and it says "your default browser is firefox" (or 
whichever is first in the list). "What?" says the user... "that's not what I'm 
experiencing..."

If you want to change the default behaviour, you need to actually change the 
default behaviour (in KRun), not just what the KCM shows by default.

The default behaviour of KRun and the default settings shown by this KCM have 
to match.

This investigation shows that this is already buggy before this patch (the 
fallback to x-scheme-handler/https in the user's mimeapps.list is missing 
here), but this patch makes it much worse, as is.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D17372

To: ngraham, #plasma, #vdg, #frameworks, dfaure
Cc: GB_2, dfaure, abetts, davidedmundson, plasma-devel, jraleigh, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, 
mart

D17372: [componentchooser KCM] Make KIO browser option the fallback only and remove from the UI

[Nathaniel Graham]

ngraham added reviewers: Frameworks, dfaure.
ngraham added a comment.


  I'm still not sure whether the feature needs to be removed entirely. I feel 
that this minimal patch probably stands on its own well enough as-is.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D17372

To: ngraham, #plasma, #vdg, #frameworks, dfaure
Cc: GB_2, dfaure, abetts, davidedmundson, plasma-devel, jraleigh, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, 
mart