D17550: Make the open url in tab feature a bit more discoverable
apol closed this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D17550 To: apol, #dolphin, ngraham, #frameworks, elvisangelaccio Cc: elvisangelaccio, kde-frameworks-devel, michaelh, ngraham, bruns
D17550: Make the open url in tab feature a bit more discoverable
elvisangelaccio accepted this revision. REPOSITORY R241 KIO BRANCH arcpatch-D17550 REVISION DETAIL https://phabricator.kde.org/D17550 To: apol, #dolphin, ngraham, #frameworks, elvisangelaccio Cc: elvisangelaccio, kde-frameworks-devel, michaelh, ngraham, bruns
D17550: Make the open url in tab feature a bit more discoverable
apol updated this revision to Diff 47706. apol added a comment. Remove unrelated change REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17550?vs=47705&id=47706 BRANCH arcpatch-D17550 REVISION DETAIL https://phabricator.kde.org/D17550 AFFECTED FILES src/filewidgets/kurlnavigator.cpp src/filewidgets/kurlnavigator.h src/filewidgets/kurlnavigatorbutton.cpp src/filewidgets/kurlnavigatorbutton_p.h To: apol, #dolphin, ngraham, #frameworks Cc: elvisangelaccio, kde-frameworks-devel, michaelh, ngraham, bruns
D17550: Make the open url in tab feature a bit more discoverable
apol updated this revision to Diff 47705. apol added a comment. add space REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17550?vs=47481&id=47705 BRANCH arcpatch-D17550 REVISION DETAIL https://phabricator.kde.org/D17550 AFFECTED FILES src/filewidgets/kurlnavigator.cpp src/filewidgets/kurlnavigator.h src/filewidgets/kurlnavigatorbutton.cpp src/filewidgets/kurlnavigatorbutton_p.h src/widgets/kfileitemactions.cpp To: apol, #dolphin, ngraham, #frameworks Cc: elvisangelaccio, kde-frameworks-devel, michaelh, ngraham, bruns
D17550: Make the open url in tab feature a bit more discoverable
apol marked an inline comment as done. apol added inline comments. INLINE COMMENTS > elvisangelaccio wrote in kurlnavigator.cpp:483 > Do we really have to put the folder name in the extry text? This will make > the popup menu very large if the folder name is long. My thinking was that it's the only action that is context-dependent it better be explicit. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D17550 To: apol, #dolphin, ngraham, #frameworks Cc: elvisangelaccio, kde-frameworks-devel, michaelh, ngraham, bruns
D17550: Make the open url in tab feature a bit more discoverable
elvisangelaccio added inline comments.
INLINE COMMENTS
> kurlnavigator.cpp:480
> +if (q->receivers(SIGNAL(tabRequested(QUrl))) > 0) {
> +for(auto button : qAsConst(m_navButtons)) {
> +if (button->geometry().contains(p)) {
Space after `for`
> kurlnavigator.cpp:483
> +const auto url = button->url();
> +QAction* openInTab =
> popup->addAction(QIcon::fromTheme(QStringLiteral("tab-new")), i18n("Open %1
> in tab", button->text()));
> +q->connect(openInTab, &QAction::triggered, q, [this, url](){
> Q_EMIT q->tabRequested(url); });
Do we really have to put the folder name in the extry text? This will make the
popup menu very large if the folder name is long.
REPOSITORY
R241 KIO
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D17550
To: apol, #dolphin, ngraham, #frameworks
Cc: elvisangelaccio, kde-frameworks-devel, michaelh, ngraham, bruns
D17550: Make the open url in tab feature a bit more discoverable
ngraham accepted this revision as: ngraham. ngraham added a comment. This revision is now accepted and ready to land. +1 for the idea and the UX as texted. No comment on the code change; I'm definitely not smart enough to understand it all! REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D17550 To: apol, #dolphin, ngraham, #frameworks Cc: kde-frameworks-devel, michaelh, ngraham, bruns
D17550: Make the open url in tab feature a bit more discoverable
apol created this revision. apol added reviewers: Dolphin, ngraham. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. apol requested review of this revision. REVISION SUMMARY Introduce a context menu item that invites to open the button under the menu in a tab. It used to just work with the middle button, now it works with control+click as well, much like in web browsers. BUG: 402073 REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D17550 AFFECTED FILES src/filewidgets/kurlnavigator.cpp src/filewidgets/kurlnavigator.h src/filewidgets/kurlnavigatorbutton.cpp src/filewidgets/kurlnavigatorbutton_p.h src/widgets/kfileitemactions.cpp To: apol, #dolphin, ngraham Cc: kde-frameworks-devel, michaelh, ngraham, bruns
D17550: Make the open url in tab feature a bit more discoverable
apol added a reviewer: Frameworks. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D17550 To: apol, #dolphin, ngraham, #frameworks Cc: kde-frameworks-devel, michaelh, ngraham, bruns
