D17609: KTextEditor: Add action for static word wrap

2018-12-26 Thread Christoph Cullmann 
This revision was automatically updated to reflect the committed changes.
Closed by commit R39:3a7a2d1ca986: KTextEditor: Add action for static word wrap 
(authored by loh.tar, committed by cullmann).

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17609?vs=47632=48232

REVISION DETAIL
  https://phabricator.kde.org/D17609

AFFECTED FILES
  src/data/katepart5ui.rc
  src/view/kateview.cpp

To: loh.tar, #ktexteditor, #vdg, cullmann
Cc: cullmann, abetts, kwrite-devel, kde-frameworks-devel, #ktexteditor, hase, 
michaelh, ngraham, bruns, demsking, sars, dhaumann

D17609: KTextEditor: Add action for static word wrap

2018-12-26 Thread Christoph Cullmann 
cullmann accepted this revision.
cullmann added a comment.
This revision is now accepted and ready to land.


  Why not ;=)

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D17609

To: loh.tar, #ktexteditor, #vdg, cullmann
Cc: cullmann, abetts, kwrite-devel, kde-frameworks-devel, #ktexteditor, hase, 
michaelh, ngraham, bruns, demsking, sars, dhaumann

D17609: KTextEditor: Add action for static word wrap

2018-12-15 Thread Andres Betts 
abetts added a comment.


  +1

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D17609

To: loh.tar, #ktexteditor, #vdg
Cc: abetts, kwrite-devel, kde-frameworks-devel, #ktexteditor, hase, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D17609: KTextEditor: Add action for static word wrap

2018-12-15 Thread loh tar 
loh.tar created this revision.
loh.tar added reviewers: KTextEditor, VDG.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
loh.tar requested review of this revision.

REVISION SUMMARY
  - Move "Show Static Word Wrap Marker" code some lines up to group related 
actions
  
  BUG:141946

TEST PLAN
  F6478656: 1544896348.png 

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D17609

AFFECTED FILES
  src/data/katepart5ui.rc
  src/view/kateview.cpp

To: loh.tar, #ktexteditor, #vdg
Cc: kwrite-devel, kde-frameworks-devel, #ktexteditor, hase, michaelh, ngraham, 
bruns, demsking, cullmann, sars, dhaumann

D17609: KTextEditor: Add action for static word wrap

2018-12-15 Thread loh tar 
loh.tar added a comment.


  - Not well tested
  - Slot code may not fit coding style but looks not bad to me
  - No Ampersand & short cut set as done by other actions

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D17609

To: loh.tar, #ktexteditor, #vdg
Cc: kwrite-devel, kde-frameworks-devel, #ktexteditor, hase, michaelh, ngraham, 
bruns, demsking, cullmann, sars, dhaumann